Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

2017-05-08 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58998/
---

(Updated May 8, 2017, 5:04 p.m.)


Review request for mesos and haosdent huang.


Changes
---

Address review comment.


Repository: mesos


Description
---

Fixed extra newline in webui for re-registered frameworks.


Diffs (updated)
-

  src/webui/master/static/framework.html 
79dd1a7fa8c41c1e09141c273cc5d2e261e578b3 


Diff: https://reviews.apache.org/r/58998/diff/2/

Changes: https://reviews.apache.org/r/58998/diff/1-2/


Testing
---

Visual inspection.

Screenshot before: http://www.neilconway.org/tmp/screenshot_before.png

Screenshot after: http://www.neilconway.org/tmp/screenshot_after.png


Thanks,

Neil Conway

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

2017-05-04 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58998/#review173992
---




src/webui/master/static/framework.html
Lines 40-41 (original), 40-41 (patched)


I think change `ng-show` to `ng-if` should be enough.

```
-

...
```


- haosdent huang


On May 4, 2017, 7:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58998/
> ---
> 
> (Updated May 4, 2017, 7:04 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed extra newline in webui for re-registered frameworks.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> 79dd1a7fa8c41c1e09141c273cc5d2e261e578b3 
> 
> 
> Diff: https://reviews.apache.org/r/58998/diff/1/
> 
> 
> Testing
> ---
> 
> Visual inspection.
> 
> Screenshot before: http://www.neilconway.org/tmp/screenshot_before.png
> 
> Screenshot after: http://www.neilconway.org/tmp/screenshot_after.png
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

2017-05-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58998/#review173991
---



Patch looks great!

Reviews applied: [58998]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 4, 2017, 7:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58998/
> ---
> 
> (Updated May 4, 2017, 7:04 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed extra newline in webui for re-registered frameworks.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> 79dd1a7fa8c41c1e09141c273cc5d2e261e578b3 
> 
> 
> Diff: https://reviews.apache.org/r/58998/diff/1/
> 
> 
> Testing
> ---
> 
> Visual inspection.
> 
> Screenshot before: http://www.neilconway.org/tmp/screenshot_before.png
> 
> Screenshot after: http://www.neilconway.org/tmp/screenshot_after.png
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

2017-05-04 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58998/
---

Review request for mesos and haosdent huang.


Repository: mesos


Description
---

Fixed extra newline in webui for re-registered frameworks.


Diffs
-

  src/webui/master/static/framework.html 
79dd1a7fa8c41c1e09141c273cc5d2e261e578b3 


Diff: https://reviews.apache.org/r/58998/diff/1/


Testing
---

Visual inspection.

Screenshot before: http://www.neilconway.org/tmp/screenshot_before.png

Screenshot after: http://www.neilconway.org/tmp/screenshot_after.png


Thanks,

Neil Conway