Re: Review Request 59063: Changed `#elif ...` to `#elif defined(...)` in Mesos.

2017-05-09 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59063/#review174271
---


Ship it!




Ship It!

- Jie Yu


On May 8, 2017, 8:48 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59063/
> ---
> 
> (Updated May 8, 2017, 8:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed `#elif ...` to `#elif defined(...)` to match `#ifdef`.
> 
> 
> Diffs
> -
> 
>   src/linux/ns.hpp da4b716e06f4041f44659e1e73f0b7ea73ab4a05 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 58ab74571fb14c6dbb1907151dc421f93e324bb5 
>   src/slave/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 
> 
> 
> Diff: https://reviews.apache.org/r/59063/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 59063: Changed #elif to #elif defined() in Mesos.

2017-05-08 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59063/
---

Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.


Repository: mesos


Description
---

Fixed mistakes that uses #elif  instead of #elif defined() 
after #ifdef .


Diffs
-

  src/linux/ns.hpp da4b716e06f4041f44659e1e73f0b7ea73ab4a05 
  src/slave/containerizer/mesos/containerizer.cpp 
58ab74571fb14c6dbb1907151dc421f93e324bb5 
  src/slave/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 


Diff: https://reviews.apache.org/r/59063/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao