---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59110/#review174382
---
Ship it!
Ship It!
- Neil Conway
On May 9, 2017, 8:32 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59110/
> ---
>
> (Updated May 9, 2017, 8:32 p.m.)
>
>
> Review request for mesos, Li Li and Neil Conway.
>
>
> Bugs: MESOS-7484
> https://issues.apache.org/jira/browse/MESOS-7484
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The test case `u8"1.0.0-b\u00e9ta"` in `VersionTest.ParseInvalid` caused
> an abort in `isctype.cpp` with VS 2017. Changing the `char` to an
> `unsigned char` prevents this.
>
>
> Diffs
> -
>
> 3rdparty/stout/include/stout/version.hpp
> 9120e42eedcfb4fc5ee41f08354441bc10914baf
>
>
> Diff: https://reviews.apache.org/r/59110/diff/1/
>
>
> Testing
> ---
>
> Build and ran `stout-tests` target on Windows. `make check` in
> `build/3rdparty/stout` on Linux.
>
> ```
> [ RUN ] VersionTest.ParseValid
> [ OK ] VersionTest.ParseValid (0 ms)
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
