Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.

2017-05-16 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218 


Diff: https://reviews.apache.org/r/59318/diff/1/


Testing
---

Make check with an without the patch.


Thanks,

Kapil Arya



Re: Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.

2017-05-22 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/
---

(Updated May 22, 2017, 4:55 p.m.)


Review request for mesos and Gilbert Song.


Changes
---

Addressed Gilbert's comments


Summary (updated)
-

Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.


Repository: mesos


Description (updated)
---

Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.


Diffs (updated)
-

  src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 


Diff: https://reviews.apache.org/r/59318/diff/2/

Changes: https://reviews.apache.org/r/59318/diff/1-2/


Testing
---

Make check with an without the patch.


Thanks,

Kapil Arya



Re: Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.

2017-05-22 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175739
---


Ship it!




Ship It!

- Gilbert Song


On May 22, 2017, 1:55 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> ---
> 
> (Updated May 22, 2017, 1:55 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d 
> 
> 
> Diff: https://reviews.apache.org/r/59318/diff/2/
> 
> 
> Testing
> ---
> 
> Make check with an without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>