Review Request 59587: Added a test for ignoring executor re-registrations.

2017-05-25 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59587/
---

Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.


Repository: mesos


Description
---

When the executor reconnect retry is enabled, the agent will ignore
any subsequent executor re-registrations since the agent cannot
correctly handle these in the steady state case.


Diffs
-

  src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df 


Diff: https://reviews.apache.org/r/59587/diff/1/


Testing
---

Ran in repetition.


Thanks,

Benjamin Mahler



Re: Review Request 59587: Added a test for ignoring executor re-registrations.

2017-05-25 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59587/#review176171
---


Ship it!





src/tests/slave_tests.cpp
Lines 7174 (patched)


ditto from previous review. helper?


- Vinod Kone


On May 26, 2017, 12:21 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59587/
> ---
> 
> (Updated May 26, 2017, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the executor reconnect retry is enabled, the agent will ignore
> any subsequent executor re-registrations since the agent cannot
> correctly handle these in the steady state case.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df 
> 
> 
> Diff: https://reviews.apache.org/r/59587/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>