Re: Review Request 59591: Removed a use of the 'default' switch case.

2017-05-25 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59591/#review176174
---


Ship it!




Ship It!

- Vinod Kone


On May 26, 2017, 1:03 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59591/
> ---
> 
> (Updated May 26, 2017, 1:03 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For enums, we instead rely on the compiler to warn us when we
> miss a switch case. With the presence of the 'default' case,
> this doesn't occur. See MESOS-3754.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 15e4d68714556ca30a766acd3b9729367df680c3 
> 
> 
> Diff: https://reviews.apache.org/r/59591/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Review Request 59591: Removed a use of the 'default' switch case.

2017-05-25 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59591/
---

Review request for mesos, Greg Mann and Vinod Kone.


Repository: mesos


Description
---

For enums, we instead rely on the compiler to warn us when we
miss a switch case. With the presence of the 'default' case,
this doesn't occur. See MESOS-3754.


Diffs
-

  src/slave/slave.cpp 15e4d68714556ca30a766acd3b9729367df680c3 


Diff: https://reviews.apache.org/r/59591/diff/1/


Testing
---


Thanks,

Benjamin Mahler