Review Request 60174: Updated the resources validation logic to allow for the endpoint format.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.apache.org/jira/browse/MESOS-7655 Repository: mesos Description --- For backwards compatibility of external tools consuming endpoints, We'll inject the "pre-reservation-refinement" format for resources without refined reservations. That is, the `Resource.role` and `Resource.reservation` fields will be filled in with the single reservation inside `Resource.reservations`. We update the validation logic to allow these resources to be valid. Diffs - src/common/resources.cpp f12ab970fbce2815a5a22e5080af9fb70c6aef9f src/v1/resources.cpp 30644ee0bfeb8498d7b10daa79c0da369201abf3 Diff: https://reviews.apache.org/r/60174/diff/1/ Testing --- Thanks, Michael Park
Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178165 --- In the commit message, can we explain why we need to update validation to support this new format? i.e., the commit message says the master is going to _emit_ this weird format, but it doesn't necessarily follow why the master needs to _accept_ inputs in this format. Seems like we should update the tests for this change, right? - Neil Conway On June 18, 2017, 10:02 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60174/ > --- > > (Updated June 18, 2017, 10:02 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > --- > > For backwards compatibility of external tools consuming endpoints, > We'll inject the "pre-reservation-refinement" format for resources > without refined reservations. That is, the `Resource.role` and > `Resource.reservation` fields will be filled in with the single > reservation inside `Resource.reservations`. > > We update the validation logic to allow these resources to be valid. > > > Diffs > - > > src/common/resources.cpp f12ab970fbce2815a5a22e5080af9fb70c6aef9f > src/v1/resources.cpp 30644ee0bfeb8498d7b10daa79c0da369201abf3 > > > Diff: https://reviews.apache.org/r/60174/diff/1/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178168 --- Ship it! Ship It! - Neil Conway On June 18, 2017, 10:02 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60174/ > --- > > (Updated June 18, 2017, 10:02 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > --- > > For backwards compatibility of external tools consuming endpoints, > We'll inject the "pre-reservation-refinement" format for resources > without refined reservations. That is, the `Resource.role` and > `Resource.reservation` fields will be present as well as > the in with the single `Resource.reservations` field. > > Since the users of the endpoints are likely to feed the result back into > Mesos, we need to update the validation logic to allow these resources > to be considered valid. > > > Diffs > - > > src/common/resources.cpp f12ab970fbce2815a5a22e5080af9fb70c6aef9f > src/v1/resources.cpp 30644ee0bfeb8498d7b10daa79c0da369201abf3 > > > Diff: https://reviews.apache.org/r/60174/diff/2/ > > > Testing > --- > > > Thanks, > > Michael Park > >
