Re: Review Request 60623: Convert "file://" URI handling to use new uri function.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/#review187348
---



Same comment for style on summary as before, also missing description. Also URI 
is inconsistently capitalized ;)


src/tests/credentials_tests.cpp
Line 94 (original), 96-97 (patched)


This exemplifies my comments on `uri::uriFromFilename`. It's unwieldy.

I'll let this issue stand for the other uses too, they're all great 
examples :)


These changes in spirit are fine, but I don't like how the URI conversion has 
to be done at all. It should be as simple as `uri::from_path(input)`.

- Andrew Schwartzmeyer


On Oct. 5, 2017, 9:03 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60623/
> ---
> 
> (Updated Oct. 5, 2017, 9:03 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Convert "file://" URI handling to use new uri function.
> 
> 
> Diffs
> -
> 
>   src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
>   src/tests/master_contender_detector_tests.cpp 
> f499136c0b981072af5bc8accf2238b7ba4bf430 
>   src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 
> 
> 
> Diff: https://reviews.apache.org/r/60623/diff/2/
> 
> 
> Testing
> ---
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60623: Convert "file://" URI handling to use new uri function.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/
---

(Updated Oct. 6, 2017, 4:03 a.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Summary (updated)
-

Convert "file://" URI handling to use new uri function.


Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description (updated)
---

Convert "file://" URI handling to use new uri function.


Diffs (updated)
-

  src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 
  src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
  src/tests/master_contender_detector_tests.cpp 
f499136c0b981072af5bc8accf2238b7ba4bf430 
  src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd 


Diff: https://reviews.apache.org/r/60623/diff/2/

Changes: https://reviews.apache.org/r/60623/diff/1-2/


Testing
---

See upstream


Thanks,

Jeff Coffler