Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/#review182491 --- Ship it! Ship It! - Till Toenshoff On Aug. 7, 2017, 10:30 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60646/ > --- > > (Updated Aug. 7, 2017, 10:30 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > This patch modifies the handling of the parallel test configure flag > for documentation purposes. With that we document proper ways to > handle both default-enabled and -disabled flags without using > arguments to 'AC_ARG_ENABLE'; the handling of '--disable-werror' is an > example of a default-enabled flag while > '--enable-parallel-test-execution' documents a default-disabled flag. > > > Diffs > - > > configure.ac 5a6e42c61e6752c3742532502dbc753071b31323 > > > Diff: https://reviews.apache.org/r/60646/diff/2/ > > > Testing > --- > > configure and build stout with different settings > (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, > `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), > `make check`. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/ --- (Updated Aug. 7, 2017, 12:30 p.m.) Review request for mesos and Till Toenshoff. Summary (updated) - Modified handling of parallel test configure flag for documentation. Repository: mesos Description (updated) --- This patch modifies the handling of the parallel test configure flag for documentation purposes. With that we document proper ways to handle both default-enabled and -disabled flags without using arguments to 'AC_ARG_ENABLE'; the handling of '--disable-werror' is an example of a default-enabled flag while '--enable-parallel-test-execution' documents a default-disabled flag. Diffs (updated) - configure.ac 5a6e42c61e6752c3742532502dbc753071b31323 Diff: https://reviews.apache.org/r/60646/diff/2/ Changes: https://reviews.apache.org/r/60646/diff/1-2/ Testing --- configure and build stout with different settings (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), `make check`. Thanks, Benjamin Bannier
