Re: Review Request 61149: Added Future::condition.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61149/#review183221
---



Looks like the summary became incorrect after the last diff update.

- Alexander Rukletsov


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61149/
> ---
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Future::condition.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> cce950509f58022e79bb51a6e72ea1a005b9cb50 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> 0c8725b9a5e64aaac6e3979e450a11e84f9bd45e 
> 
> 
> Diff: https://reviews.apache.org/r/61149/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 61149: Added Future::condition.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61149/#review181641
---




3rdparty/libprocess/include/process/future.hpp
Lines 155-156 (patched)


I'm not sure callers will grasp this, to me this is stringification of the 
future, and in the READY case it would print `'Ready with X'`. Is there a way 
to acheive this when T isn't printable (e.g. `'Ready with '`


- Benjamin Mahler


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61149/
> ---
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Future::condition.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> cce950509f58022e79bb51a6e72ea1a005b9cb50 
> 
> 
> Diff: https://reviews.apache.org/r/61149/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 61149: Added Future::condition.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61149/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Added Future::condition.


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
cce950509f58022e79bb51a6e72ea1a005b9cb50 


Diff: https://reviews.apache.org/r/61149/diff/1/


Testing
---

make check


Thanks,

Benjamin Hindman