Re: Review Request 61151: Used Future::recover in Mesos.

2017-08-03 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61151/#review182135
---


Ship it!




Ship It!

- Benjamin Mahler


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61151/
> ---
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used Future::recover in Mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 64180944f8680828781168faa67417489abf1bc8 
> 
> 
> Diff: https://reviews.apache.org/r/61151/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 61151: Used Future::recover in Mesos.

2017-07-29 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61151/#review181764
---




src/slave/containerizer/mesos/io/switchboard.cpp
Line 1646 (original), 1641 (patched)


Calling `future.failure()` will crash in the discarded or abandonment 
cases, no?


- Benjamin Mahler


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61151/
> ---
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used Future::recover in Mesos.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 64180944f8680828781168faa67417489abf1bc8 
> 
> 
> Diff: https://reviews.apache.org/r/61151/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 61151: Used Future::recover in Mesos.

2017-07-26 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61151/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Used Future::recover in Mesos.


Diffs
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
64180944f8680828781168faa67417489abf1bc8 


Diff: https://reviews.apache.org/r/61151/diff/1/


Testing
---

make check


Thanks,

Benjamin Hindman