Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61534/
---

(Updated Aug. 9, 2017, 6:56 p.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description (updated)
---

This patch adds 'SlaveTest.GetStateTaskGroupPending', which confirms
the fix for MESOS-7871. The test verifies that requests to the agent's
'/state' endpoint are successful when there are pending tasks on the
agent which were launched as part of a task group.


Diffs
-

  src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 


Diff: https://reviews.apache.org/r/61534/diff/2/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*GetStateTaskGroupPending*" 
--gtest_repeat=1000`


Thanks,

Greg Mann

Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61534/
---

(Updated Aug. 9, 2017, 6:55 p.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description (updated)
---

Added test to verify the fix for a failed agent assertion.


Diffs (updated)
-

  src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 


Diff: https://reviews.apache.org/r/61534/diff/2/

Changes: https://reviews.apache.org/r/61534/diff/1-2/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*GetStateTaskGroupPending*" 
--gtest_repeat=1000`


Thanks,

Greg Mann

Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

2017-08-09 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61534/#review182511
---


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 1825 (patched)


Maybe clarify here that we just want to make sure it doesn't crsah? Ideally 
we would be looking to make sure the pending tasks show up (which I hope we 
already have a test for for non task groups?)


- Benjamin Mahler


On Aug. 9, 2017, 6:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61534/
> ---
> 
> (Updated Aug. 9, 2017, 6:28 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7871
> https://issues.apache.org/jira/browse/MESOS-7871
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds 'SlaveTest.GetStateTaskGroupPending', which confirms
> the fix for MESOS-7871. The test verifies that requests to the agent's
> '/state' endpoint are successful when there are pending tasks on the
> agent which were launched as part of a task group.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 
> 
> 
> Diff: https://reviews.apache.org/r/61534/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*GetStateTaskGroupPending*" 
> --gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 61534: Added test to verify the fix for a failed agent assertion.

2017-08-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61534/
---

Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-7871
https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description
---

This patch adds 'SlaveTest.GetStateTaskGroupPending', which confirms
the fix for MESOS-7871. The test verifies that requests to the agent's
'/state' endpoint are successful when there are pending tasks on the
agent which were launched as part of a task group.


Diffs
-

  src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 


Diff: https://reviews.apache.org/r/61534/diff/1/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*GetStateTaskGroupPending*" 
--gtest_repeat=1000`


Thanks,

Greg Mann