Re: Review Request 61569: Added the field `signal` to the `KillNestedContainer` call.

2017-08-14 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61569/#review182882
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 10, 2017, 7:32 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61569/
> ---
> 
> (Updated Aug. 10, 2017, 7:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This would be used later for sending signals (SIGTERM, SIGKILL etc.)
> to the running container. Previously, SIGKILL was used by default.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
>   include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 
> 
> 
> Diff: https://reviews.apache.org/r/61569/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 61569: Added the field `signal` to the `KillNestedContainer` call.

2017-08-14 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61569/#review182878
---


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 10, 2017, 7:32 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61569/
> ---
> 
> (Updated Aug. 10, 2017, 7:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This would be used later for sending signals (SIGTERM, SIGKILL etc.)
> to the running container. Previously, SIGKILL was used by default.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
>   include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 
> 
> 
> Diff: https://reviews.apache.org/r/61569/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 61569: Added the field `signal` to the `KillNestedContainer` call.

2017-08-10 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61569/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879


Repository: mesos


Description
---

This would be used later for sending signals (SIGTERM, SIGKILL etc.)
to the running container. Previously, SIGKILL was used by default.


Diffs
-

  include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
  include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 


Diff: https://reviews.apache.org/r/61569/diff/1/


Testing
---

make check


Thanks,

Anand Mazumdar