Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-15 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185477
---


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 13, 2017, 6:01 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62246/
> ---
> 
> (Updated Sept. 13, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds workaround for an incorrect docker file execution on
> Apache CI due to a docker bug, see:
> https://github.com/moby/moby/issues/9547
> Quote from the docker issue:
> The execution of `chmod +x b.sh` just prior to trying to running b.sh
> is leaving it in the 'Text file busy' state for long enough that then
> running it fails.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 
> 
> 
> Diff: https://reviews.apache.org/r/62246/diff/4/
> 
> 
> Testing
> ---
> 
> 1. internal CI
> 
> 2. Apache CI:
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Buildbot-Test/29/
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Buildbot-Test/30/
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Buildbot-Test/31/
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185448
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62246']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (264 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (249 ms)
[--] 30 tests from ContentType/SchedulerTest (25529 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (931 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1064 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2081 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (127 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (149 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (317 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (355277 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246/logs/mesos-tests-stderr.log):

```
I0914 19:54:47.165302 16320 master.cpp:8418] Removing framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3- (default)
I0914 19:54:47.165302 16320 master.cpp:3267] Deactivating framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3- (default)
I0914 19:54:47.166303 11680 hierarchical.cpp:412] Deactivated framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3-
I0914 19:54:47.166303 14656 slave.cpp:3235] Shutting down framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3-
I0914 19:54:47.166303 16320 master.cpp:8993] Updating the state of task 
cfc93bf7-027d-4f60-a988-b4c0e32b89ab of framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0914 19:54:47.166303 14656 slave.cpp:5731] Shutting down executor 'default' of 
framework 4f4e7bbe-c768-4be9-bf43-b311e38122e3- (via HTTP)
I0914 19:54:47.182754 16320 master.cpp:9087] Removing task 
cfc93bf7-027d-4f60-a988-b4c0e32b89ab with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 4f4e7bbe-c768-4be9-bf43-b311e38122e3- on agent 
4f4e7bbe-c768-4be9-bf43-b311e38122e3-S0 at slave(254)@10.3.1.5:56350 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 19:54:47.193755 16320 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 4f4e7bbe-c768-4be9-bf43-b311e38122e3- on agent 
4f4e7bbe-c768-4be9-bf43-b311e38122e3-S0 at slave(254)@10.3.1.5:56350 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 19:54:47.213755 14656 hierarchical.cpp:355] Removed framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3-
E0914 19:54:47.214756 15472 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0914 19:54:47.215755 15524 scheduler.cpp:444] Re-detecting master
I0914 19:54:47.219755 15524 scheduler.cpp:470] New master detected at 
master@10.3.1.5:56350
I0914 19:54:47.231756 15524 slave.cpp:5407] Executor 'default' of framework 
4f4e7bbe-c768-4be9-bf43-b311e38122e3- exited with status 0
I0914 19:54:47.231756 15524 slave.cpp:5511] Cleaning up executor 'default' of 
framework 4f4e7bbe-c768-4be9-bf43-b311e38122e3- (via HTTP)
W0914 19:54:47.232756 15720 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 4f4e7bbe-c768-4be9-bf43-b311e38122e3- on agent

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185422
---



PASS: Mesos patch 62246 was successfully built and tested.

Reviews applied: `['62246']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246

- Mesos Reviewbot Windows


On Sept. 13, 2017, 6:01 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62246/
> ---
> 
> (Updated Sept. 13, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds workaround for an incorrect docker file execution on
> Apache CI due to a docker bug, see:
> https://github.com/moby/moby/issues/9547
> Quote from the docker issue:
> The execution of `chmod +x b.sh` just prior to trying to running b.sh
> is leaving it in the 'Text file busy' state for long enough that then
> running it fails.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 
> 
> 
> Diff: https://reviews.apache.org/r/62246/diff/4/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185340
---



FAIL: The filename, directory name, or volume label syntax is incorrect.

Reviews applied: `['62246']`

Failed command: ``

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246

- Mesos Reviewbot Windows


On Sept. 13, 2017, 6:01 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62246/
> ---
> 
> (Updated Sept. 13, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds workaround for an incorrect docker file execution on
> Apache CI due to a docker bug, see:
> https://github.com/moby/moby/issues/9547
> Quote from the docker issue:
> The execution of `chmod +x b.sh` just prior to trying to running b.sh
> is leaving it in the 'Text file busy' state for long enough that then
> running it fails.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 
> 
> 
> Diff: https://reviews.apache.org/r/62246/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-13 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/
---

(Updated Sept. 13, 2017, 6:01 p.m.)


Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.


Repository: mesos


Description
---

This patch adds workaround for an incorrect docker file execution on
Apache CI due to a docker bug, see:
https://github.com/moby/moby/issues/9547
Quote from the docker issue:
The execution of `chmod +x b.sh` just prior to trying to running b.sh
is leaving it in the 'Text file busy' state for long enough that then
running it fails.


Diffs (updated)
-

  support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 


Diff: https://reviews.apache.org/r/62246/diff/3/

Changes: https://reviews.apache.org/r/62246/diff/2-3/


Testing (updated)
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185259
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62246']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246/logs/mesos-tests-stdout.log):

```

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (890 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1017 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2025 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (145 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (161 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (347 ms 
total)

[--] Global test environment tear-down
C:\mesos\mesos\src\tests\environment.cpp(756): error: Failed
Tests completed with child processes remaining:
-+- 10360 00DEB5EFE47C
 --- 12976 00DEB5EFE47C
[==] 627 tests from 66 test cases ran. (334671 ms total)
[  PASSED  ] 625 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where 
GetParam() = "mesos"

 2 FAILED TESTS
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246/logs/mesos-tests-stderr.log):

```
I0913 03:40:09.330443 10836 master.cpp:8418] Removing framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f- (default)
I0913 03:40:09.330443 10836 master.cpp:3267] Deactivating framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f- (default)
I0913 03:40:09.330443  3004 hierarchical.cpp:412] Deactivated framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-
I0913 03:40:09.331439 10512 slave.cpp:3235] Shutting down framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-
I0913 03:40:09.331439 10836 master.cpp:8993] Updating the state of task 
1276933e-df6b-4126-b9d2-ab93a59f58f1 of framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 03:40:09.331439 10512 slave.cpp:5731] Shutting down executor 'default' of 
framework 3541ce17-6339-4cd6-b93d-afd3e7da6b7f- (via HTTP)
I0913 03:40:09.344758 10836 master.cpp:9087] Removing task 
1276933e-df6b-4126-b9d2-ab93a59f58f1 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 3541ce17-6339-4cd6-b93d-afd3e7da6b7f- on agent 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-S0 at slave(254)@10.3.1.5:64581 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 03:40:09.355754 10836 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 3541ce17-6339-4cd6-b93d-afd3e7da6b7f- on agent 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-S0 at slave(254)@10.3.1.5:64581 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 03:40:09.368953  2780 hierarchical.cpp:355] Removed framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-
E0913 03:40:09.368953  3004 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 03:40:09.369956 12192 scheduler.cpp:444] Re-detecting master
I0913 03:40:09.373952 12192 scheduler.cpp:470] New master detected at 
master@10.3.1.5:64581
I0913 03:40:09.386953 12192 slave.cpp:5407] Executor 'default' of framework 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f- exited with status 0
I0913 03:40:09.386953 12192 slave.cpp:5511] Cleaning up executor 'default' of 
framework 3541ce17-6339-4cd6-b93d-afd3e7da6b7f- (via HTTP)
W0913 03:40:09.388953 12284 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 3541ce17-6339-4cd6-b93d-afd3e7da6b7f- on agent 
3541ce17-6339-4cd6-b93d-afd3e7da6b7f-S0 at

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185202
---



Bad review!

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot Windows


On Sept. 12, 2017, 2:33 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62246/
> ---
> 
> (Updated Sept. 12, 2017, 2:33 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds workaround for an incorrect docker file execution on
> Apache CI due to a docker bug, see:
> https://github.com/moby/moby/issues/9547
> Quote from the docker issue:
> The execution of `chmod +x b.sh` just prior to trying to running b.sh
> is leaving it in the 'Text file busy' state for long enough that then
> running it fails.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 
> 
> 
> Diff: https://reviews.apache.org/r/62246/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-12 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/
---

Review request for mesos.


Repository: mesos


Description
---

This patch adds workaround for an incorrect docker file execution on
Apache CI due to a docker bug, see:
https://github.com/moby/moby/issues/9547
Quote from the docker issue:
The execution of `chmod +x b.sh` just prior to trying to running b.sh
is leaving it in the 'Text file busy' state for long enough that then
running it fails.


Diffs
-

  support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 


Diff: https://reviews.apache.org/r/62246/diff/1/


Testing
---


Thanks,

Andrei Budnik