Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185306
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62279']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (237 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (228 ms)
[--] 30 tests from ContentType/SchedulerTest (25341 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (943 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (967 
ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2005 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (142 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (367 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (354348 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stderr.log):

```
I0913 16:47:16.687176 14904 master.cpp:8418] Removing framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (default)
I0913 16:47:16.687176 14904 master.cpp:3267] Deactivating framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (default)
I0913 16:47:16.688171  9376 hierarchical.cpp:412] Deactivated framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
I0913 16:47:16.688171 13648 slave.cpp:3235] Shutting down framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
I0913 16:47:16.688171 14904 master.cpp:8993] Updating the state of task 
b7d108cf-9966-418e-8d2f-72106efcd3c3 of framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 16:47:16.698185 13648 slave.cpp:5731] Shutting down executor 'default' of 
framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (via HTTP)
I0913 16:47:16.702172 14904 master.cpp:9087] Removing task 
b7d108cf-9966-418e-8d2f-72106efcd3c3 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-S0 at slave(254)@10.3.1.5:51572 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 16:47:16.722234 14904 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-S0 at slave(254)@10.3.1.5:51572 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 16:47:16.726174  9376 hierarchical.cpp:355] Removed framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
E0913 16:47:16.726174 14148 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 16:47:16.728173 10748 scheduler.cpp:444] Re-detecting master
I0913 16:47:16.731173 14904 scheduler.cpp:470] New master detected at 
master@10.3.1.5:51572
I0913 16:47:16.743175 15300 slave.cpp:5407] Executor 'default' of framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- exited with status 0
I0913 16:47:16.743175 15300 slave.cpp:5511] Cleaning up executor 'default' of 
framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (via HTTP)
W0913 16:47:16.743175 10748 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185301
---


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 13, 2017, 12:03 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62279/
> ---
> 
> (Updated Sept. 13, 2017, 12:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, 
> and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processes terminated by `os::killtree` exit normally with a status code
> on windows, but killed by a signal on linux. Previously, we expected
> a process to be killed by a signal, which causes test failure on
> windows. Since we don't care about exact value of a returned status
> code in this test, this check was removed.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 186b8333c02ba3b9257e19437c6d689761085362 
> 
> 
> Diff: https://reviews.apache.org/r/62279/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185293
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62279']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (263 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (266 ms)
[--] 30 tests from ContentType/SchedulerTest (25143 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (939 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1083 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2108 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (137 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (331 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (340096 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stderr.log):

```
I0913 14:14:05.771536 12776 master.cpp:8418] Removing framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (default)
I0913 14:14:05.771536 12776 master.cpp:3267] Deactivating framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (default)
I0913 14:14:05.772536 12440 hierarchical.cpp:412] Deactivated framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
I0913 14:14:05.772536 13824 slave.cpp:3235] Shutting down framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
I0913 14:14:05.772536 12776 master.cpp:8993] Updating the state of task 
cfceaa94-9706-4731-9e4b-cac83e493616 of framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 14:14:05.772536 13824 slave.cpp:5731] Shutting down executor 'default' of 
framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- (via HTTP)
I0913 14:14:05.790535 12776 master.cpp:9087] Removing task 
cfceaa94-9706-4731-9e4b-cac83e493616 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-S0 at slave(254)@10.3.1.5:50507 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 14:14:05.805546 12776 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-S0 at slave(254)@10.3.1.5:50507 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 14:14:05.817531 11872 hierarchical.cpp:355] Removed framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
E0913 14:14:05.817531 13484 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 14:14:05.819530 12440 scheduler.cpp:444] Re-detecting master
I0913 14:14:05.822530 12440 scheduler.cpp:470] New master detected at 
master@10.3.1.5:50507
I0913 14:14:05.833529 12440 slave.cpp:5407] Executor 'default' of framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- exited with status 0
I0913 14:14:05.834529 12440 slave.cpp:5511] Cleaning up executor 'default' of 
framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- (via HTTP)
W0913 14:14:05.839529 13824 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 

Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Andrei Budnik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, 
and Qian Zhang.


Repository: mesos


Description
---

Processes terminated by `os::killtree` exit normally with status code
on windows. This patch fixes expected status code of a killed task.


Diffs
-

  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 


Diff: https://reviews.apache.org/r/62279/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik