Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-18 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62306/#review185599
---


Ship it!




Ship It!

- Gilbert Song


On Sept. 13, 2017, 1:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62306/
> ---
> 
> (Updated Sept. 13, 2017, 1:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an index in the mesos containerizer doc about isolators.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 
> 
> 
> Diff: https://reviews.apache.org/r/62306/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-15 Thread Jie Yu 


> On Sept. 15, 2017, 12:05 a.m., James Peach wrote:
> > docs/mesos-containerizer.md
> > Lines 29 (patched)
> > 
> >
> > Can you append the undocumented isolators to the list?
> > 
> > - network/port_mapping
> > - environment_secret
> > - volume/secret
> > - volume/image
> > - volume/host_path
> > - appc/runtime
> > - posix/cpu
> > - posix/mem
> > - volume/sandbox_path
> > - cgroups/*

In a separate patch (https://reviews.apache.org/r/62365/)


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62306/#review185435
---


On Sept. 13, 2017, 8:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62306/
> ---
> 
> (Updated Sept. 13, 2017, 8:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an index in the mesos containerizer doc about isolators.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 
> 
> 
> Diff: https://reviews.apache.org/r/62306/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-14 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62306/#review185435
---




docs/mesos-containerizer.md
Lines 29 (patched)


Can you append the undocumented isolators to the list?

- network/port_mapping
- environment_secret
- volume/secret
- volume/image
- volume/host_path
- appc/runtime
- posix/cpu
- posix/mem
- volume/sandbox_path
- cgroups/*


- James Peach


On Sept. 13, 2017, 8:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62306/
> ---
> 
> (Updated Sept. 13, 2017, 8:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an index in the mesos containerizer doc about isolators.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 
> 
> 
> Diff: https://reviews.apache.org/r/62306/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-13 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62306/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Added an index in the mesos containerizer doc about isolators.


Diffs
-

  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62306/diff/1/


Testing
---


Thanks,

Jie Yu