Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-26 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
---

(Updated Sept. 26, 2017, 8:45 p.m.)


Review request for .


Changes
---

Review comments.


Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445


Repository: mesos


Description
---

This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.

Review: https://reviews.apache.org/r/62481


Diffs (updated)
-

  src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
  src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
  src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 


Diff: https://reviews.apache.org/r/62481/diff/3/

Changes: https://reviews.apache.org/r/62481/diff/2-3/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-26 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
---

(Updated Sept. 26, 2017, 8:45 p.m.)


Review request for .


Changes
---

Review comments.


Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445


Repository: mesos


Description
---

This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.

Review: https://reviews.apache.org/r/62481


Diffs (updated)
-

  src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
  src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
  src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 


Diff: https://reviews.apache.org/r/62481/diff/3/

Changes: https://reviews.apache.org/r/62481/diff/2-3/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-26 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186310
---




src/tests/gc_tests.cpp
Line 381 (original)


I think we should wait until `__recover` gets executed to be sure that no 
gc has been scheduled.


- Vinod Kone


On Sept. 26, 2017, 4:59 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> ---
> 
> (Updated Sept. 26, 2017, 4:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
> 
> Review: https://reviews.apache.org/r/62481
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
>   src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
>   src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
> 
> 
> Diff: https://reviews.apache.org/r/62481/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-26 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
---

(Updated Sept. 26, 2017, 4:59 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445


Repository: mesos


Description (updated)
---

This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.

Review: https://reviews.apache.org/r/62481


Diffs (updated)
-

  src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
  src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
  src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 


Diff: https://reviews.apache.org/r/62481/diff/2/

Changes: https://reviews.apache.org/r/62481/diff/1-2/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-25 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186185
---




src/tests/slave_recovery_tests.cpp
Line 3137 (original), 3137 (patched)


s/different/same/


- Vinod Kone


On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> ---
> 
> (Updated Sept. 21, 2017, 8:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
>   src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
>   src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
> 
> 
> Diff: https://reviews.apache.org/r/62481/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-25 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186184
---




src/tests/gc_tests.cpp
Line 384 (original), 374 (patched)


What's the point of advancing the clock if the slave process is not up?


- Vinod Kone


On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> ---
> 
> (Updated Sept. 21, 2017, 8:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
>   src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
>   src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
> 
> 
> Diff: https://reviews.apache.org/r/62481/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-21 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review185929
---



FAIL: Mesos tests failed to build.

Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', 
'62481']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481/logs/mesos-tests-build-cmake-stdout.log):

```
  
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): 
warning C4090: 'function': different 'const' qualifiers 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
c:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): 
warning C4716: 'pthread_cond_broadcast': must return a value 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
c:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): 
warning C4716: 'pthread_cond_wait': must return a value 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): 
warning C4996: 'fopen': This function or variable may be unsafe. Consider using 
fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): 
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): 
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): 
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): 
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): 
warnin

Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

2017-09-21 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445


Repository: mesos


Description
---

This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.


Diffs
-

  src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
  src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
  src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 


Diff: https://reviews.apache.org/r/62481/diff/1/


Testing
---

make check


Thanks,

Anand Mazumdar