Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-12-31 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/#review194608
---




src/tests/api_tests.cpp
Lines 4347-4358 (patched)


Could we leverage the helper `AgentAPITest::post()`?


- Gilbert Song


On Dec. 28, 2017, 12:06 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62853/
> ---
> 
> (Updated Dec. 28, 2017, 12:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for `PRUNE_IMAGES` operator API call.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 9246f4222548f8d19a8f4f89fb3c22ecae5b58b0 
> 
> 
> Diff: https://reviews.apache.org/r/62853/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-12-28 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/
---

(Updated Dec. 28, 2017, 8:06 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Rebase and fix mock usage.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added test for `PRUNE_IMAGES` operator API call.


Diffs (updated)
-

  src/tests/api_tests.cpp 9246f4222548f8d19a8f4f89fb3c22ecae5b58b0 


Diff: https://reviews.apache.org/r/62853/diff/6/

Changes: https://reviews.apache.org/r/62853/diff/5-6/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-11-22 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/
---

(Updated Nov. 22, 2017, 10:50 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Rebase.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added test for `PRUNE_IMAGES` operator API call.


Diffs (updated)
-

  src/tests/api_tests.cpp 66cb059c96ff9ecda594e13de9e5dc3909f3 


Diff: https://reviews.apache.org/r/62853/diff/4/

Changes: https://reviews.apache.org/r/62853/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-11-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/#review191390
---



PASS: Mesos patch 62853 was successfully built and tested.

Reviews applied: `['55334', '55335', '59687', '62997', '56721', '60471', 
'56722', '62853']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62853

- Mesos Reviewbot Windows


On Nov. 17, 2017, 8:48 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62853/
> ---
> 
> (Updated Nov. 17, 2017, 8:48 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for `PRUNE_IMAGES` operator API call.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c9c50b91ddd7c3317c1188f878753ad3bd5c3941 
> 
> 
> Diff: https://reviews.apache.org/r/62853/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-11-17 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/
---

(Updated Nov. 17, 2017, 4:48 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added test for `PRUNE_IMAGES` operator API call.


Diffs (updated)
-

  src/tests/api_tests.cpp c9c50b91ddd7c3317c1188f878753ad3bd5c3941 


Diff: https://reviews.apache.org/r/62853/diff/3/

Changes: https://reviews.apache.org/r/62853/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-10-17 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/
---

(Updated Oct. 17, 2017, 3:30 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added test for `PRUNE_IMAGES` operator API call.


Diffs (updated)
-

  src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 


Diff: https://reviews.apache.org/r/62853/diff/2/

Changes: https://reviews.apache.org/r/62853/diff/1-2/


Testing
---


Thanks,

Zhitao Li

Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

2017-10-09 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62853/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added test for `PRUNE_IMAGES` operator API call.


Diffs
-

  src/tests/api_tests.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3 


Diff: https://reviews.apache.org/r/62853/diff/1/


Testing
---


Thanks,

Zhitao Li