Re: Review Request 63437: Slave heartbeat add message sender distinguish.

2018-01-01 Thread Andy Pang 


> On 十一月 3, 2017, 10:26 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 4996-5001 (patched)
> > 
> >
> > Can you explain the context for this change? The change itself seems 
> > reasonable, but I would like to understand what prompted you to add this.

we meet double master leader, and the incorrect leader send the ping-pong to 
the agent, agent can't recognize even if it detect the real correct leader.


- Andy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/#review190074
---


On 十月 31, 2017, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63437/
> ---
> 
> (Updated 十月 31, 2017, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave ping-pong message add master from judge.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083d 
> 
> 
> Diff: https://reviews.apache.org/r/63437/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

2017-11-03 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/#review190074
---




src/slave/slave.cpp
Lines 4996-5001 (patched)


Can you explain the context for this change? The change itself seems 
reasonable, but I would like to understand what prompted you to add this.


- Vinod Kone


On Oct. 31, 2017, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63437/
> ---
> 
> (Updated Oct. 31, 2017, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave ping-pong message add master from judge.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083d 
> 
> 
> Diff: https://reviews.apache.org/r/63437/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

2017-10-31 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/#review189766
---



PASS: Mesos patch 63437 was successfully built and tested.

Reviews applied: `['63437']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63437

- Mesos Reviewbot Windows


On Oct. 31, 2017, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63437/
> ---
> 
> (Updated Oct. 31, 2017, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave ping-pong message add master from judge.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083d 
> 
> 
> Diff: https://reviews.apache.org/r/63437/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

2017-10-31 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/#review189722
---



Patch looks great!

Reviews applied: [63437]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 31, 2017, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63437/
> ---
> 
> (Updated Oct. 31, 2017, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave ping-pong message add master from judge.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083d 
> 
> 
> Diff: https://reviews.apache.org/r/63437/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Review Request 63437: Slave heartbeat add message sender distinguish.

2017-10-30 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/
---

Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
---

Slave ping-pong message add master from judge.


Diffs
-

  src/slave/slave.cpp 337083d 


Diff: https://reviews.apache.org/r/63437/diff/1/


Testing
---

make check


Thanks,

Andy Pang