Re: Review Request 63638: Added callable once support in Future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/#review192916 --- Ship it! Ship It! - Michael Park On Nov. 21, 2017, 9:51 a.m., Dmitry Zhuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63638/ > --- > > (Updated Nov. 21, 2017, 9:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > --- > > `Future` guarantees that callbacks are called at most once, so it can > use `lambda::CallableOnce` to expicitly declare this, and allow > corresponding optimizations with moves. > > > Diffs > - > > 3rdparty/libprocess/include/process/future.hpp > d48dfd795fdc4021270621522a365e3cad4102a6 > 3rdparty/libprocess/src/tests/future_tests.cpp > bb7a1c83e136136088e60e4d187e2a52df49f454 > > > Diff: https://reviews.apache.org/r/63638/diff/3/ > > > Testing > --- > > make check > > > Thanks, > > Dmitry Zhuk > >
Re: Review Request 63638: Added callable once support in Future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/ --- (Updated Nov. 21, 2017, 5:51 p.m.) Review request for mesos, Benjamin Mahler and Michael Park. Changes --- Rebased. Included "abandoned" support. Bugs: MESOS-6972 https://issues.apache.org/jira/browse/MESOS-6972 Repository: mesos Description --- `Future` guarantees that callbacks are called at most once, so it can use `lambda::CallableOnce` to expicitly declare this, and allow corresponding optimizations with moves. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp d48dfd795fdc4021270621522a365e3cad4102a6 3rdparty/libprocess/src/tests/future_tests.cpp bb7a1c83e136136088e60e4d187e2a52df49f454 Diff: https://reviews.apache.org/r/63638/diff/2/ Changes: https://reviews.apache.org/r/63638/diff/1-2/ Testing --- make check Thanks, Dmitry Zhuk
Review Request 63638: Added callable once support in Future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972 https://issues.apache.org/jira/browse/MESOS-6972 Repository: mesos Description --- `Future` guarantees that callbacks are called at most once, so it can use `lambda::CallableOnce` to expicitly declare this, and allow corresponding optimizations with moves. Diffs - 3rdparty/libprocess/include/process/future.hpp 4cf44ba1a7052d5f84beb8fd6914b8e9e0437c0a 3rdparty/libprocess/src/tests/future_tests.cpp 76a32bd69499e52ea1623ab982d65e1c7a0cbd32 Diff: https://reviews.apache.org/r/63638/diff/1/ Testing --- make check Thanks, Dmitry Zhuk
