Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63904/#review191818
---


Ship it!




Ship It!

- Jie Yu


On Nov. 23, 2017, 9:47 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63904/
> ---
> 
> (Updated Nov. 23, 2017, 9:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph 
> Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7561
> https://issues.apache.org/jira/browse/MESOS-7561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `type` and `name` fields are introduced to uniquely identify a CSI
> service bundle. The purpose of the new proto and these two fields is to
> decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
> allow tasks to directly use non-resource volumes (such as NFS volumes).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   include/mesos/v1/mesos.hpp 26b4596024f4da987e73efb1cfc03ff97bd2fc5d 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
>   src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94 
> 
> 
> Diff: https://reviews.apache.org/r/63904/diff/4/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63904/
---

(Updated Nov. 23, 2017, 9:47 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph Wu, 
and Jan Schlicht.


Changes
---

Addressed jieyu's comment.


Bugs: MESOS-7561
https://issues.apache.org/jira/browse/MESOS-7561


Repository: mesos


Description
---

The `type` and `name` fields are introduced to uniquely identify a CSI
service bundle. The purpose of the new proto and these two fields is to
decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
allow tasks to directly use non-resource volumes (such as NFS volumes).


Diffs (updated)
-

  include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
  include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
  include/mesos/v1/mesos.hpp 26b4596024f4da987e73efb1cfc03ff97bd2fc5d 
  include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
  src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
  src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94 


Diff: https://reviews.apache.org/r/63904/diff/4/

Changes: https://reviews.apache.org/r/63904/diff/3-4/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63904/#review191780
---




src/common/type_utils.cpp
Lines 102 (patched)


you need to update src/v1/mesos.cpp as well.


- Jie Yu


On Nov. 21, 2017, 5:32 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63904/
> ---
> 
> (Updated Nov. 21, 2017, 5:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph 
> Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7561
> https://issues.apache.org/jira/browse/MESOS-7561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `type` and `name` fields are introduced to uniquely identify a CSI
> service bundle. The purpose of the new proto and these two fields is to
> decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
> allow tasks to directly use non-resource volumes (such as NFS volumes).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
> 
> 
> Diff: https://reviews.apache.org/r/63904/diff/3/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63904/
---

(Updated Nov. 21, 2017, 5:32 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph Wu, 
and Jan Schlicht.


Changes
---

Addressed jdef's comments. Removed unused `operator!=` for 
`ResourceProviderInfo`. The equality operator will be used in unit tests down 
in the chain.


Summary (updated)
-

Updated the top-level `CSIPluginInfo` proto.


Bugs: MESOS-7561
https://issues.apache.org/jira/browse/MESOS-7561


Repository: mesos


Description (updated)
---

The `type` and `name` fields are introduced to uniquely identify a CSI
service bundle. The purpose of the new proto and these two fields is to
decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
allow tasks to directly use non-resource volumes (such as NFS volumes).


Diffs (updated)
-

  include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
  include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
  include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
  src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 


Diff: https://reviews.apache.org/r/63904/diff/2/

Changes: https://reviews.apache.org/r/63904/diff/1-2/


Testing (updated)
---

make


Thanks,

Chun-Hung Hsiao