Re: Review Request 63959: Optimized resources logging in master.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63959/#review191754
---


Fix it, then Ship it!




Thanks! Left a comment below but will take care of this for you!


src/master/master.cpp
Lines 6869-6870 (patched)


Thanks for the comment! Looks like we would benefit from them in the three 
additional cases below as well?


- Benjamin Mahler


On Nov. 22, 2017, 1:24 p.m., Dmitry Zhuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63959/
> ---
> 
> (Updated Nov. 22, 2017, 1:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When master logs agent or task resources, it uses `operator <<` for raw
> protobuf data, which outputs resources in JSON format, and is rather
> slow. However resources are known to be valid and refined when logged by
> master, so it's faster to use `operator <<` after protobuf is converted
> to `Resources`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 
> 
> 
> Diff: https://reviews.apache.org/r/63959/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>

Re: Review Request 63959: Optimized resources logging in master.

[Dmitry Zhuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63959/
---

(Updated Nov. 22, 2017, 1:24 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Summary (updated)
-

Optimized resources logging in master.


Repository: mesos


Description (updated)
---

When master logs agent or task resources, it uses `operator <<` for raw
protobuf data, which outputs resources in JSON format, and is rather
slow. However resources are known to be valid and refined when logged by
master, so it's faster to use `operator <<` after protobuf is converted
to `Resources`.


Diffs (updated)
-

  src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 


Diff: https://reviews.apache.org/r/63959/diff/2/

Changes: https://reviews.apache.org/r/63959/diff/1-2/


Testing
---

make check


Thanks,

Dmitry Zhuk