Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64074/#review203664
---



Bad patch!

Reviews applied: [64074, 61158, 64909, 64908, 64907, 64906, 61157, 61154, 
61153, 61152, 61151, 61150, 61149, 61148, 61147, 55324, 55323, 55322, 55321]

Failed command: python support/apply-reviews.py -n -r 55323

Error:
2018-05-23 15:43:18 URL:https://reviews.apache.org/r/55323/diff/raw/ 
[3479/3479] -> "55323.patch" [1]
error: patch failed: src/master/master.hpp:2158
error: src/master/master.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22522/console

- Mesos Reviewbot


On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64074/
> ---
> 
> (Updated Nov. 26, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and 
> Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ENABLE_HTTP_SERVER option for cmake.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318 
> 
> 
> Diff: https://reviews.apache.org/r/64074/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64074/#review203638
---



FAIL: Failed to apply the dependent review: 55323.

Failed command: `python.exe .\support\apply-reviews.py -n -r 55323`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64074

Relevant logs:

- 
[apply-review-55323-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64074/logs/apply-review-55323-stdout.log):

```
error: patch failed: src/master/master.hpp:2158
error: src/master/master.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64074/
> ---
> 
> (Updated Nov. 26, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and 
> Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ENABLE_HTTP_SERVER option for cmake.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318 
> 
> 
> Diff: https://reviews.apache.org/r/64074/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64074/#review191971
---


Fix it, then Ship it!




Why just cmake?


cmake/CompilationConfigure.cmake
Lines 100-103 (patched)


For someone that doesn't know the details, this naming seems a little 
unintuitive, i.e. doesn't libprocess already have an http server?

I'm also a little worried about how long it will take us to migrate to the 
new http server code. Is there a plan in place for the transition of the 
default? Why not transition the default to TRUE to begin with? Is the primary 
concern the lack of benchmarks? Would be good to document this for posterity in 
some of these commits.


- Benjamin Mahler


On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64074/
> ---
> 
> (Updated Nov. 26, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and 
> Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ENABLE_HTTP_SERVER option for cmake.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 
> 
> 
> Diff: https://reviews.apache.org/r/64074/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64074/
---

Review request for mesos, Avinash sridharan and Benjamin Mahler.


Repository: mesos


Description
---

Added ENABLE_HTTP_SERVER option for cmake.


Diffs
-

  cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 


Diff: https://reviews.apache.org/r/64074/diff/1/


Testing
---

make check


Thanks,

Benjamin Hindman