Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/#review192951
---


Ship it!




Ship It!

- Gaston Kleiman


On Dec. 4, 2017, 11:33 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64143/
> ---
> 
> (Updated Dec. 4, 2017, 11:33 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
> https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new event is used to send offer operation status udpate
> acknowledgements to resource providers.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
>   src/resource_provider/storage/provider.cpp 
> d35b0d02992e3730ca47906b34c21e1ba9c653e7 
>   src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
> 
> 
> Diff: https://reviews.apache.org/r/64143/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/#review192891
---


Ship it!




Ship It!

- Jie Yu


On Dec. 5, 2017, 7:33 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64143/
> ---
> 
> (Updated Dec. 5, 2017, 7:33 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
> https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new event is used to send offer operation status udpate
> acknowledgements to resource providers.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
>   include/mesos/v1/resource_provider/resource_provider.proto 
> 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
>   src/resource_provider/storage/provider.cpp 
> d35b0d02992e3730ca47906b34c21e1ba9c653e7 
>   src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
> 
> 
> Diff: https://reviews.apache.org/r/64143/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/
---

(Updated Dec. 5, 2017, 7:33 a.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.


Bugs: MESOS-8186
https://issues.apache.org/jira/browse/MESOS-8186


Repository: mesos


Description
---

The new event is used to send offer operation status udpate
acknowledgements to resource providers.


Diffs (updated)
-

  include/mesos/resource_provider/resource_provider.proto 
2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
  include/mesos/v1/resource_provider/resource_provider.proto 
465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
  src/resource_provider/storage/provider.cpp 
d35b0d02992e3730ca47906b34c21e1ba9c653e7 
  src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 


Diff: https://reviews.apache.org/r/64143/diff/3/

Changes: https://reviews.apache.org/r/64143/diff/2-3/


Testing
---

make check


Thanks,

Greg Mann

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/
---

(Updated Dec. 4, 2017, 10:24 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.


Bugs: MESOS-8186
https://issues.apache.org/jira/browse/MESOS-8186


Repository: mesos


Description
---

The new event is used to send offer operation status udpate
acknowledgements to resource providers.


Diffs (updated)
-

  include/mesos/resource_provider/resource_provider.proto 
2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
  include/mesos/v1/resource_provider/resource_provider.proto 
465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
  src/resource_provider/storage/provider.cpp 
d35b0d02992e3730ca47906b34c21e1ba9c653e7 


Diff: https://reviews.apache.org/r/64143/diff/2/

Changes: https://reviews.apache.org/r/64143/diff/1-2/


Testing
---

make check


Thanks,

Greg Mann

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/#review192389
---




include/mesos/resource_provider/resource_provider.proto
Line 37 (original), 37 (patched)


please update v1 proto too.



include/mesos/resource_provider/resource_provider.proto
Lines 38 (patched)


See my comment in the following patch. Let's make the code consistent on 
naming.


- Jie Yu


On Nov. 29, 2017, 5:50 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64143/
> ---
> 
> (Updated Nov. 29, 2017, 5:50 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
> https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new event is used to send offer operation status udpate
> acknowledgements to resource providers.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> 615a2ab8a00f4da3906ad0ae322a885c84b3574b 
>   src/resource_provider/storage/provider.cpp 
> 49c042cdb1837860aaedde2e48f318ed5ac8b1d1 
> 
> 
> Diff: https://reviews.apache.org/r/64143/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/
---

Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.


Bugs: MESOS-8186
https://issues.apache.org/jira/browse/MESOS-8186


Repository: mesos


Description
---

The new event is used to send offer operation status udpate
acknowledgements to resource providers.


Diffs
-

  include/mesos/resource_provider/resource_provider.proto 
615a2ab8a00f4da3906ad0ae322a885c84b3574b 
  src/resource_provider/storage/provider.cpp 
49c042cdb1837860aaedde2e48f318ed5ac8b1d1 


Diff: https://reviews.apache.org/r/64143/diff/1/


Testing
---

make check


Thanks,

Greg Mann