Re: Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/#review192218 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 1:18 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64187/ > --- > > (Updated Nov. 30, 2017, 1:18 a.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This was used but not included, and broke on Windows because no other > headers included it. > > > Diffs > - > > src/tests/flags.hpp 0050fc99198d29a2e4597fa2a3c138ac29b9c379 > > > Diff: https://reviews.apache.org/r/64187/diff/1/ > > > Testing > --- > > `make check` on CentOS 7 > > All tests passed on Windows 10 (with exception of known failing test > `HealthCheckTest.HealthyTaskViaTCP`). `stout-tests` passed under > `--gtest_repeat=100`. > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/ --- (Updated Nov. 29, 2017, 5:18 p.m.) Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Repository: mesos Description --- This was used but not included, and broke on Windows because no other headers included it. Diffs - src/tests/flags.hpp 0050fc99198d29a2e4597fa2a3c138ac29b9c379 Diff: https://reviews.apache.org/r/64187/diff/1/ Testing (updated) --- `make check` on CentOS 7 All tests passed on Windows 10 (with exception of known failing test `HealthCheckTest.HealthyTaskViaTCP`). `stout-tests` passed under `--gtest_repeat=100`. Thanks, Andrew Schwartzmeyer
Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Repository: mesos Description --- This was used but not included, and broke on Windows because no other headers included it. Diffs - src/tests/flags.hpp 0050fc99198d29a2e4597fa2a3c138ac29b9c379 Diff: https://reviews.apache.org/r/64187/diff/1/ Testing --- Tests pending... Thanks, Andrew Schwartzmeyer
