Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Repository: mesos Description --- Along with this, a number of changes were made: 1. Debug versions of cURL build with libcurl-d and curl-d.exe. Modified build system to handle these issues. 2. cURL is built to make use of SChannel (native Windows encryption) by default. This means we no longer need to build Mesos with cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. Diffs - 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d Diff: https://reviews.apache.org/r/64720/diff/1/ Testing --- Thanks, Jeff Coffler
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194170 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 19, 2017, 11:33 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 11:33 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
> On Dec. 19, 2017, 11:35 a.m., Andrew Schwartzmeyer wrote: > > Ship It! For context: this change is necessary to support using the fetcher for `https` downloads on Windows. While we previously built cURL with OpenSSL support, on Windows this does not come with a ca-certificate bundle, and so it would refuse to download because it (correctly) could not verify the TLS connection. By upgrading cURL, we were able to switch to "WinSSL" aka SChannel, which is the native Windows crypto implementation, and thus has access to the OS's certificates. This fixes fetching over TLS connections, and can be enabled uncondtionally, regardless of the use of OpenSSL for libevent. Because we upgraded cURL, we had to update our build due to significant changes to the upstsream build system (i.e. the debug build of the executable is now called `curl-d.exe`, etc.). - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194170 --- On Dec. 19, 2017, 11:33 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 11:33 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194179 --- FAIL: Cannot overwrite the item D:DCOSmesosbuild-outputbinariescurl.exe with itself. Reviews applied: `['64720']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720 - Mesos Reviewbot Windows On Dec. 19, 2017, 7:33 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 7:33 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
> On Dec. 19, 2017, 9:12 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Cannot overwrite the item D:DCOSmesosbuild-outputbinariescurl.exe > > with itself. > > > > Reviews applied: `['64720']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720 I'm not 100% sure why reviewbot had this problem. I tested successfully on both Windows and Linux, and ran both STOUT and MESOS tests on both Windows on Linux prior to submitting the review. Note that my tests require changes that Andy made, so to get successful test passes on Windows (and to get a successful manual test), Andy's changes need to be in the chain. My changes require Andy's changes, which I indicated in "depends on". The logs (http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720/logs/mesos-tests-stdout.log) show that it built and passed all tests successfully. We will follow up with our CI team to fix this failure, but we can ignore it here. - Jeff --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194179 --- On Dec. 19, 2017, 7:33 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 7:33 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
> On Dec. 19, 2017, 1:12 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Cannot overwrite the item D:DCOSmesosbuild-outputbinariescurl.exe > > with itself. > > > > Reviews applied: `['64720']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720 > > Jeff Coffler wrote: > I'm not 100% sure why reviewbot had this problem. I tested successfully > on both Windows and Linux, and ran both STOUT and MESOS tests on both Windows > on Linux prior to submitting the review. Note that my tests require changes > that Andy made, so to get successful test passes on Windows (and to get a > successful manual test), Andy's changes need to be in the chain. My changes > require Andy's changes, which I indicated in "depends on". > > The logs > (http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720/logs/mesos-tests-stdout.log) > show that it built and passed all tests successfully. We will follow up with > our CI team to fix this failure, but we can ignore it here. So, before John's changed went in to automatically include `curl.exe` in the build output on Windows (next to `mesos-agent.exe` for health checks), a stopgap was added to the CI system so that the DC/OS builds had working health checks. Now that the name changed from `curl.exe` to `curl-d.exe`, the code is having an issue, and needed to be deleted. I opened a PR [here](https://github.com/Microsoft/mesos-jenkins/pull/16). - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194179 --- On Dec. 19, 2017, 2:29 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 2:29 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gaston Kleiman, > John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
> On Dec. 19, 2017, 1:12 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Cannot overwrite the item D:DCOSmesosbuild-outputbinariescurl.exe > > with itself. > > > > Reviews applied: `['64720']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720 > > Jeff Coffler wrote: > I'm not 100% sure why reviewbot had this problem. I tested successfully > on both Windows and Linux, and ran both STOUT and MESOS tests on both Windows > on Linux prior to submitting the review. Note that my tests require changes > that Andy made, so to get successful test passes on Windows (and to get a > successful manual test), Andy's changes need to be in the chain. My changes > require Andy's changes, which I indicated in "depends on". > > The logs > (http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64720/logs/mesos-tests-stdout.log) > show that it built and passed all tests successfully. We will follow up with > our CI team to fix this failure, but we can ignore it here. > > Andrew Schwartzmeyer wrote: > So, before John's changed went in to automatically include `curl.exe` in > the build output on Windows (next to `mesos-agent.exe` for health checks), a > stopgap was added to the CI system so that the DC/OS builds had working > health checks. > > Now that the name changed from `curl.exe` to `curl-d.exe`, the code is > having an issue, and needed to be deleted. > > I opened a PR [here](https://github.com/Microsoft/mesos-jenkins/pull/16). Merged, committing. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64720/#review194179 --- On Dec. 19, 2017, 2:29 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64720/ > --- > > (Updated Dec. 19, 2017, 2:29 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gaston Kleiman, > John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Along with this, a number of changes were made: > > 1. Debug versions of cURL build with libcurl-d and curl-d.exe. >Modified build system to handle these issues. > 2. cURL is built to make use of SChannel (native Windows encryption) >by default. This means we no longer need to build Mesos with >cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that. > > > Diffs > - > > 3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 > 3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d > > > Diff: https://reviews.apache.org/r/64720/diff/1/ > > > Testing > --- > > > Thanks, > > Jeff Coffler > >
