Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review196188 --- Ship it! Ship It! - Till Toenshoff On Jan. 18, 2018, 10:53 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65208/ > --- > > (Updated Jan. 18, 2018, 10:53 a.m.) > > > Review request for mesos, Armand Grillet and Till Toenshoff. > > > Bugs: MESOS-7979 > https://issues.apache.org/jira/browse/MESOS-7979 > > > Repository: mesos > > > Description > --- > > Reviewboard's `rbt` can be configured to guess field when creating > review requests. With that setting it e.g., uses the first line of a > commit as description, and the remainder as description. If the commit > message has no body it will use the summary as description as well, > leading to redundant information in commit messages which committers > usually remove again manually before committing. > > This patch prevents reusing a reviewboard description which is > identical to the summary when synthesising commit message with > `apply_reviews.py`. > > > Diffs > - > > support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 > > > Diff: https://reviews.apache.org/r/65208/diff/1/ > > > Testing > --- > > Applied a commit with redundant description; the commit message only contains > the reviewboard URL as body. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review195826 --- Ship it! Ship It! - Armand Grillet On Jan. 18, 2018, 10:53 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65208/ > --- > > (Updated Jan. 18, 2018, 10:53 a.m.) > > > Review request for mesos, Armand Grillet and Till Toenshoff. > > > Bugs: MESOS-7979 > https://issues.apache.org/jira/browse/MESOS-7979 > > > Repository: mesos > > > Description > --- > > Reviewboard's `rbt` can be configured to guess field when creating > review requests. With that setting it e.g., uses the first line of a > commit as description, and the remainder as description. If the commit > message has no body it will use the summary as description as well, > leading to redundant information in commit messages which committers > usually remove again manually before committing. > > This patch prevents reusing a reviewboard description which is > identical to the summary when synthesising commit message with > `apply_reviews.py`. > > > Diffs > - > > support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 > > > Diff: https://reviews.apache.org/r/65208/diff/1/ > > > Testing > --- > > Applied a commit with redundant description; the commit message only contains > the reviewboard URL as body. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review195715 --- PASS: Mesos patch 65208 was successfully built and tested. Reviews applied: `['65208']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65208 - Mesos Reviewbot Windows On Jan. 18, 2018, 2:53 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65208/ > --- > > (Updated Jan. 18, 2018, 2:53 a.m.) > > > Review request for mesos, Armand Grillet and Till Toenshoff. > > > Bugs: MESOS-7979 > https://issues.apache.org/jira/browse/MESOS-7979 > > > Repository: mesos > > > Description > --- > > Reviewboard's `rbt` can be configured to guess field when creating > review requests. With that setting it e.g., uses the first line of a > commit as description, and the remainder as description. If the commit > message has no body it will use the summary as description as well, > leading to redundant information in commit messages which committers > usually remove again manually before committing. > > This patch prevents reusing a reviewboard description which is > identical to the summary when synthesising commit message with > `apply_reviews.py`. > > > Diffs > - > > support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 > > > Diff: https://reviews.apache.org/r/65208/diff/1/ > > > Testing > --- > > Applied a commit with redundant description; the commit message only contains > the reviewboard URL as body. > > > Thanks, > > Benjamin Bannier > >
Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/ --- Review request for mesos, Armand Grillet and Till Toenshoff. Bugs: MESOS-7979 https://issues.apache.org/jira/browse/MESOS-7979 Repository: mesos Description --- Reviewboard's `rbt` can be configured to guess field when creating review requests. With that setting it e.g., uses the first line of a commit as description, and the remainder as description. If the commit message has no body it will use the summary as description as well, leading to redundant information in commit messages which committers usually remove again manually before committing. This patch prevents reusing a reviewboard description which is identical to the summary when synthesising commit message with `apply_reviews.py`. Diffs - support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 Diff: https://reviews.apache.org/r/65208/diff/1/ Testing --- Applied a commit with redundant description; the commit message only contains the reviewboard URL as body. Thanks, Benjamin Bannier
