Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, Jie Yu, Michael Park, and Neil Conway.


Repository: mesos


Description
---

Updated the v1/mesos.proto to keep consistancy with general mesos.proto.


Diffs
-

  include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 


Diff: https://reviews.apache.org/r/65252/diff/1/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-19 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/#review195869
---



PASS: Mesos patch 65252 was successfully built and tested.

Reviews applied: `['65203', '65252']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65252

- Mesos Reviewbot Windows


On Jan. 20, 2018, 2:05 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65252/
> ---
> 
> (Updated Jan. 20, 2018, 2:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
> Greg Mann, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the v1/mesos.proto to keep consistancy with general mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 
> 
> 
> Diff: https://reviews.apache.org/r/65252/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-22 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/#review195923
---


Fix it, then Ship it!





include/mesos/v1/mesos.proto
Line 1310 (original), 1308 (patched)


New line here as in `include/mesos/mesos.proto`?


- Chun-Hung Hsiao


On Jan. 20, 2018, 2:05 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65252/
> ---
> 
> (Updated Jan. 20, 2018, 2:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
> Greg Mann, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the v1/mesos.proto to keep consistancy with general mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 
> 
> 
> Diff: https://reviews.apache.org/r/65252/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/
---

(Updated Jan. 22, 2018, 1:59 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, Jie Yu, Michael Park, and Neil Conway.


Repository: mesos


Description
---

Updated the v1/mesos.proto to keep consistancy with general mesos.proto.


Diffs (updated)
-

  include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 


Diff: https://reviews.apache.org/r/65252/diff/2/

Changes: https://reviews.apache.org/r/65252/diff/1-2/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-22 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/#review195950
---


Fix it, then Ship it!





include/mesos/v1/mesos.proto
Line 2459 (original), 2470 (patched)


Thanks for the cleanup!

I did a diff, and in the v0 proto there's only one space after the period 
in this line.

So I'd say we should: `s/meta-data.  /meta-data. /`


- Gaston Kleiman


On Jan. 22, 2018, 1:59 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65252/
> ---
> 
> (Updated Jan. 22, 2018, 1:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
> Greg Mann, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the v1/mesos.proto to keep consistancy with general mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 
> 
> 
> Diff: https://reviews.apache.org/r/65252/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65252/
---

(Updated Jan. 22, 2018, 3:21 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, Jie Yu, Michael Park, and Neil Conway.


Repository: mesos


Description
---

Updated the v1/mesos.proto to keep consistancy with general mesos.proto.


Diffs (updated)
-

  include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d 


Diff: https://reviews.apache.org/r/65252/diff/3/

Changes: https://reviews.apache.org/r/65252/diff/2-3/


Testing
---


Thanks,

Gilbert Song