Re: Review Request 65312: Refactored authorization logic in the master.

2018-03-08 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
---

(Updated March 8, 2018, 1:25 p.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs (updated)
-

  src/common/protobuf_utils.hpp 2ef1c9a4c2986e6f254e28387635bc01bb0b3259 
  src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271 
  src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad 
  src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb 
  src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35 


Diff: https://reviews.apache.org/r/65312/diff/5/

Changes: https://reviews.apache.org/r/65312/diff/4-5/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 65312: Refactored authorization logic in the master.

2018-03-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/#review198853
---


Fix it, then Ship it!




Thanks Alexander, this is amazing! Much appreciated. And thanks to BenH for the 
inspiration :)


src/master/http.cpp
Line 867 (original), 838 (patched)


Nit: indented too far.



src/master/http.cpp
Line 4442 (original), 4138 (patched)


Nit: `&` is mis-placed.



src/master/master.cpp
Lines 11241-11242 (original), 11228-11229 (patched)


Nit: not indented enough.


- Greg Mann


On Feb. 27, 2018, 8:29 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65312/
> ---
> 
> (Updated Feb. 27, 2018, 8:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
> https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch makes uses of the new `ObjectApprovers` class which greatly
> simplifies the logic for constructing and using authorization.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad 
>   src/master/master.hpp 1fadbe61f774e8ca9926af4e39b3d6c8e24fe5df 
>   src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 
> 
> 
> Diff: https://reviews.apache.org/r/65312/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 65312: Refactored authorization logic in the master.

2018-02-27 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
---

(Updated Feb. 27, 2018, 9:29 a.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Changes
---

rebase.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs (updated)
-

  src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
  src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
  src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad 
  src/master/master.hpp 1fadbe61f774e8ca9926af4e39b3d6c8e24fe5df 
  src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 


Diff: https://reviews.apache.org/r/65312/diff/4/

Changes: https://reviews.apache.org/r/65312/diff/3-4/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 65312: Refactored authorization logic in the master.

2018-02-05 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
---

(Updated Feb. 5, 2018, 11:58 a.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs (updated)
-

  src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
  src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
  src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381 


Diff: https://reviews.apache.org/r/65312/diff/2/

Changes: https://reviews.apache.org/r/65312/diff/1-2/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 65312: Refactored authorization logic in the master.

2018-01-24 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs
-

  src/common/protobuf_utils.hpp 0ff7239dd6b8f74119fdd97531d94af21fd0500c 
  src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/65312/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas