Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-02-12 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review197254
---



Patch looks great!

Reviews applied: [65348]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 12, 2018, 10:56 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Feb. 12, 2018, 10:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 76c86f8fb10339af263b6831ac1e58bc54f88c55 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-02-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review197253
---



PASS: Mesos patch 65348 was successfully built and tested.

Reviews applied: `['65348']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65348

- Mesos Reviewbot Windows


On Feb. 12, 2018, 10:56 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Feb. 12, 2018, 10:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 76c86f8fb10339af263b6831ac1e58bc54f88c55 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-02-12 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/
---

(Updated Feb. 12, 2018, 11:56 a.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Changes
---

Addressed issues.


Bugs: MESOS-8490
https://issues.apache.org/jira/browse/MESOS-8490


Repository: mesos


Description (updated)
---

Under rare circumstances, the clock would have to be advances to trigger
a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
master. We also wait for old offers to be rescinded before waiting for
updated offers as sometimes the old offer could be received erroneously.


Diffs (updated)
-

  src/tests/master_tests.cpp 76c86f8fb10339af263b6831ac1e58bc54f88c55 


Diff: https://reviews.apache.org/r/65348/diff/3/

Changes: https://reviews.apache.org/r/65348/diff/2-3/


Testing
---

make check

`src/mesos-tests --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
--gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 8 
-m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations to 
trigger the flakyness in the old code. And only when the host is under heavy 
load.


Thanks,

Jan Schlicht

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-02-05 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review196821
---


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8733 (patched)


Let's settle the clock here.


- Benjamin Bannier


On Jan. 26, 2018, 2:31 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Jan. 26, 2018, 2:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-01-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review196343
---



PASS: Mesos patch 65348 was successfully built and tested.

Reviews applied: `['65348']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65348

- Mesos Reviewbot Windows


On Jan. 26, 2018, 1:31 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Jan. 26, 2018, 1:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-01-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review196339
---



PASS: Mesos patch 65348 was successfully built and tested.

Reviews applied: `['65348']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65348

- Mesos Reviewbot Windows


On Jan. 26, 2018, 1:31 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Jan. 26, 2018, 1:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-01-26 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/
---

(Updated Jan. 26, 2018, 2:31 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Changes
---

Removed TODO.


Bugs: MESOS-8490
https://issues.apache.org/jira/browse/MESOS-8490


Repository: mesos


Description (updated)
---

Under rare circumstances, the clock would have to be advances to trigger
a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
master. We also wait for old offers to be rescinded before waiting for
updated offers as sometimes the old offer could be received erroneously.


Diffs (updated)
-

  src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 


Diff: https://reviews.apache.org/r/65348/diff/2/

Changes: https://reviews.apache.org/r/65348/diff/1-2/


Testing
---

make check

`src/mesos-tests --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
--gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 8 
-m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations to 
trigger the flakyness in the old code. And only when the host is under heavy 
load.


Thanks,

Jan Schlicht

***UNCHECKED*** Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-01-26 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review196332
---




src/tests/master_tests.cpp
Lines 8615-8616 (original), 8615-8616 (patched)


Remove the comment as well!


- Alexander Rukletsov


On Jan. 26, 2018, 12:55 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> ---
> 
> (Updated Jan. 26, 2018, 12:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
> https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 4a284c4e9c26b39d1e88b405f8b904f43b902b02 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> `src/mesos-tests 
> --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
> --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 
> 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations 
> to trigger the flakyness in the old code. And only when the host is under 
> heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

2018-01-26 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/
---

Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Bugs: MESOS-8490
https://issues.apache.org/jira/browse/MESOS-8490


Repository: mesos


Description
---

Under rare circumstances, the clock would have to be advanced to trigger
a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
master. We also wait for old offers to be rescinded before waiting for
updated offers as sometimes the old offer could be received erroneously.


Diffs
-

  src/tests/master_tests.cpp 4a284c4e9c26b39d1e88b405f8b904f43b902b02 


Diff: https://reviews.apache.org/r/65348/diff/1/


Testing
---

make check

`src/mesos-tests --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers 
--gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 8 
-m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations to 
trigger the flakyness in the old code. And only when the host is under heavy 
load.


Thanks,

Jan Schlicht