Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

2018-01-31 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65361/#review196591
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2018, 10:09 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65361/
> ---
> 
> (Updated Jan. 29, 2018, 10:09 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe 
> 
> 
> Diff: https://reviews.apache.org/r/65361/diff/4/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>



Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

2018-01-29 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65361/#review196483
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2018, 10:09 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65361/
> ---
> 
> (Updated Jan. 29, 2018, 10:09 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe 
> 
> 
> Diff: https://reviews.apache.org/r/65361/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>



Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

2018-01-29 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65361/
---

(Updated Jan. 29, 2018, 2:09 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Don't try to copy an `AgentID` to a `SlaveID`.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.


Diffs (updated)
-

  src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe 


Diff: https://reviews.apache.org/r/65361/diff/2/

Changes: https://reviews.apache.org/r/65361/diff/1-2/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman



Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

2018-01-26 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65361/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.


Diffs
-

  src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe 


Diff: https://reviews.apache.org/r/65361/diff/1/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman