Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

2018-02-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65363/#review197053
---


Fix it, then Ship it!





src/master/validation.cpp
Lines 614 (patched)


s/affcting/affecting/

I can fix this while committing.


- Greg Mann


On Feb. 1, 2018, 11:50 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65363/
> ---
> 
> (Updated Feb. 1, 2018, 11:50 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
> 
> 
> Diff: https://reviews.apache.org/r/65363/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

2018-02-01 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65363/
---

(Updated Feb. 1, 2018, 3:50 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Added a TODO here regarding agent default resources.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.


Diffs (updated)
-

  src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 


Diff: https://reviews.apache.org/r/65363/diff/2/

Changes: https://reviews.apache.org/r/65363/diff/1-2/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

2018-02-01 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65363/#review196643
---




src/master/validation.cpp
Lines 613-615 (patched)


Should we leave a TODO here regarding agent default resources, or do we 
think we'll be using an explicit RP ID for those?


- Greg Mann


On Jan. 26, 2018, 10:08 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65363/
> ---
> 
> (Updated Jan. 26, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
> 
> 
> Diff: https://reviews.apache.org/r/65363/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

2018-01-26 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65363/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.


Diffs
-

  src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 


Diff: https://reviews.apache.org/r/65363/diff/1/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman