Re: Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65509/#review196912
---


Fix it, then Ship it!




We should also note in the description that `curl` on Windows is built 
_unconditionally_, and furthermore, is placed in a location such that it can 
always be found (as part of the fix for health checks).

That is, it is not incidental that we build `curl` on Windows and can find it. 
It's a requirement of `mesos-agent` that it is built and findable.


src/tests/environment.cpp
Lines 223 (patched)


Nit: this should be `false` instead of `0` to match the above return type 
(boolean).


- Andrew Schwartzmeyer


On Feb. 5, 2018, 11:53 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65509/
> ---
> 
> (Updated Feb. 5, 2018, 11:53 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the 'curl.exe' executable is built on part of Windows (it's a
> build target), it will always exist for test purposes.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd 
> 
> 
> Diff: https://reviews.apache.org/r/65509/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65509/#review196845
---



PASS: Mesos patch 65509 was successfully built and tested.

Reviews applied: `['65508', '65509']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65509

- Mesos Reviewbot Windows


On Feb. 5, 2018, 7:53 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65509/
> ---
> 
> (Updated Feb. 5, 2018, 7:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the 'curl.exe' executable is built on part of Windows (it's a
> build target), it will always exist for test purposes.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd 
> 
> 
> Diff: https://reviews.apache.org/r/65509/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65509/
---

Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715


Repository: mesos


Description
---

Since the 'curl.exe' executable is built on part of Windows (it's a
build target), it will always exist for test purposes.


Diffs
-

  src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd 


Diff: https://reviews.apache.org/r/65509/diff/1/


Testing
---


Thanks,

Jeff Coffler