Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform.

2018-02-05 Thread Jeff Coffler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65510/
---

Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715


Repository: mesos


Description
---

Enable 'curl' uri_fetcher tests on Windows platform.


Diffs
-

  src/tests/uri_fetcher_tests.cpp 8a40f46b215bb1f267a59a9edfca83445f86b430 


Diff: https://reviews.apache.org/r/65510/diff/1/


Testing
---


Thanks,

Jeff Coffler



Re: Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform.

2018-02-05 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65510/#review196833
---



PASS: Mesos patch 65510 was successfully built and tested.

Reviews applied: `['65508', '65509', '65510']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65510

- Mesos Reviewbot Windows


On Feb. 5, 2018, 7:54 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65510/
> ---
> 
> (Updated Feb. 5, 2018, 7:54 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable 'curl' uri_fetcher tests on Windows platform.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp 8a40f46b215bb1f267a59a9edfca83445f86b430 
> 
> 
> Diff: https://reviews.apache.org/r/65510/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>



Re: Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform.

2018-02-06 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65510/#review196913
---


Ship it!




Nit: Fix the summary and description.

- Andrew Schwartzmeyer


On Feb. 5, 2018, 11:54 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65510/
> ---
> 
> (Updated Feb. 5, 2018, 11:54 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable 'curl' uri_fetcher tests on Windows platform.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp 8a40f46b215bb1f267a59a9edfca83445f86b430 
> 
> 
> Diff: https://reviews.apache.org/r/65510/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>