Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/#review201587
---


Ship it!




Ship It!

- Greg Mann


On April 11, 2018, 9:18 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66219/
> ---
> 
> (Updated April 11, 2018, 9:18 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to create grow and shrink volume in test.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e 
> 
> 
> Diff: https://reviews.apache.org/r/66219/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/
---

(Updated April 11, 2018, 2:18 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Fix proper macros.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added helper functions to create grow and shrink volume in test.


Diffs (updated)
-

  src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e 


Diff: https://reviews.apache.org/r/66219/diff/5/

Changes: https://reviews.apache.org/r/66219/diff/4-5/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/
---

(Updated March 26, 2018, 11:38 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Review comments.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added helper functions to create grow and shrink volume in test.


Diffs (updated)
-

  src/tests/mesos.hpp 01fd1c2bf21ef96dbab0769a1c1c92d7e3b60032 


Diff: https://reviews.apache.org/r/66219/diff/3/

Changes: https://reviews.apache.org/r/66219/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/#review200015
---


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 1320 (patched)


Indent by 4 spaces instead of 2 and break the parameters into two lines. 
Ditto below.


- Chun-Hung Hsiao


On March 26, 2018, 4:54 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66219/
> ---
> 
> (Updated March 26, 2018, 4:54 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to create grow and shrink volume in test.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 
> 
> 
> Diff: https://reviews.apache.org/r/66219/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/
---

Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman.


Repository: mesos


Description
---

Added helper functions to create grow and shrink volume in test.


Diffs
-

  src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 


Diff: https://reviews.apache.org/r/66219/diff/1/


Testing
---


Thanks,

Zhitao Li