Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202212
---



Patch looks great!

Reviews applied: [66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 1, 2018, 4:43 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated May 1, 2018, 4:43 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202203
---



PASS: Mesos patch 66293 was successfully built and tested.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', 
'66291', '66293']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

- Mesos Reviewbot Windows


On May 1, 2018, 9:43 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated May 1, 2018, 9:43 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
---

(Updated May 1, 2018, 9:43 a.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Review comments.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

Tested default executor support of `max_completion_time`.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 


Diff: https://reviews.apache.org/r/66293/diff/6/

Changes: https://reviews.apache.org/r/66293/diff/5-6/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-30 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202160
---


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1764 (patched)


I think it would be a little safer to make this task just run "exit 0" 
since it might take a long time to start up on a slow CI host.


- James Peach


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201819
---



Patch looks great!

Reviews applied: [66481, 66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-23 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201813
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', 
'66291', '66293']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.KillTask/1
[   OK ] ContentType/SchedulerTest.KillTask/1 (14927 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/0
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/0
 (14682 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/1
 (14627 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/0
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/0
 (14801 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1
 (14179 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0 
(14767 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 
(14841 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/0
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (14660 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/1
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (14903 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (14539 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (14427 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/0
[   OK ] ContentType/SchedulerTest.Revive/0 (14650 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/1
[   OK ] ContentType/SchedulerTest.Revive/1 (14386 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/0
[   OK ] ContentType/SchedulerTest.Suppress/0 (14642 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/1
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stderr.log):

```
I0424 05:04:34.089884  8184 master.cpp:1411] Framework 
364e13be-0829-4622-a1d3-aafe15544912- (default) disconnected
I0424 05:04:34.089884  8184 master.cpp:3259] Deactivating framework 
364e13be-0829-4622-a1d3-aafe15544912- (default)
I0424 05:04:34.090879 13968 hierarchical.cpp:405] Deactivated framework 
364e13be-0829-4622-a1d3-aafe15544912-
W0424 05:04:34.091893  8184 master.hpp:2342] Unable to send event to framework 
364e13be-0829-4622-a1d3-aafe15544912- (default): connection closed
I0424 05:04:34.091893  8184 master.cpp:11069] Removing offer 
364e13be-0829-4622-a1d3-aafe15544912-O1
I0424 05:04:34.091893  8184 master.cpp:3236] Disconnecting framework 
364e13be-0829-4622-a1d3-aafe15544912- (default)
I0424 05:04:34.092893  8184 master.cpp:1426] Giving framework 
364e13be-0829-4622-a1d3-aafe15544912- (default) 0ns to failover
I0424 05:04:34.094152 12436 master.cpp:8935] Framework failover timeout, 
removing framework 364e13be-0829-4622-a1d3-aafe15544912- (default)
I0424 05:04:34.094152 12436 master.cpp:9829] Removing framework 
364e13be-0829-4622-a1d3-aafe15544912- (default)
W0424 05:04:34.094152 11476 slave.cpp:3902] Ignoring shutdown framework message 
for 364e13be-0829-4622-a1d3-aafe15544912- because the agent has not yet 
registered with the master
I0424 05:04:34.094894  7956 hierarchical.cpp:344] Removed framework 
364e13be-0829-4622-a1d3-aafe15544912-
I0424 05:04:34.096894 15552 slave.cpp:919] Agent terminating
I0424 05:04:34.096894  7292 master.cpp:1296] Agent 
364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 
(winbldsrv-02) disconnected
I0424 05:04:34.096894  7292 master.cpp:3296] Disconnecting agent 
364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 
(winbldsrv-02)
I0424 05:04:34.097995  7292 master.cpp:3315] Deactivating agent 
364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 
(winbldsrv-02)
I0424 05:04:34.098883 11476 hie

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-12 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201085
---



Patch looks great!

Reviews applied: [66481, 66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201051
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', 
'66291', '66293']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-08 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200720
---



Patch looks great!

Reviews applied: [66481, 66258, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200714
---



PASS: Mesos patch 66293 was successfully built and tested.

Reviews applied: `['66481', '66258', '66259', '66260', '66283', '66284', 
'66291', '66293']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

- Mesos Reviewbot Windows


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> ---
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
---

(Updated April 7, 2018, 5:54 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Rename and updated test.


Summary (updated)
-

Tested default executor support of `max_completion_time`.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

Tested default executor support of `max_completion_time`.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66293/diff/2/

Changes: https://reviews.apache.org/r/66293/diff/1-2/


Testing
---


Thanks,

Zhitao Li