Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/ --- (Updated April 17, 2018, 7:20 p.m.) Review request for mesos, Benjamin Bannier, Greg Mann, James DeFelice, and Jie Yu. Changes --- Unified the way we mark experimental APIs. Bugs: MESOS-8787 https://issues.apache.org/jira/browse/MESOS-8787 Repository: mesos Description (updated) --- This patch marks the `CREATE_VOLUME`, `DESTROY_VOLUME`, `CREATE_BLOCK` and `DESTROY_BLOCK` as experimental APIs. It also unifies the way we mark experimental APIs. Diffs (updated) - include/mesos/mesos.proto 2c2f63688e579602334add8e242e2da96508cf06 include/mesos/v1/mesos.proto edbf5fad47fe56fc46a0133536e46870eb553f32 Diff: https://reviews.apache.org/r/66616/diff/3/ Changes: https://reviews.apache.org/r/66616/diff/2-3/ Testing --- No need for testing since only comments are changed. Thanks, Chun-Hung Hsiao
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/#review201282 --- Ship it! Ship It! - James DeFelice On April 16, 2018, 11:31 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66616/ > --- > > (Updated April 16, 2018, 11:31 p.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8787 > https://issues.apache.org/jira/browse/MESOS-8787 > > > Repository: mesos > > > Description > --- > > Marked volume/block creation and destroy operations as experimental. > > > Diffs > - > > include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 > include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 > > > Diff: https://reviews.apache.org/r/66616/diff/2/ > > > Testing > --- > > No need for testing since only comments are changed. > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/ --- (Updated April 16, 2018, 11:31 p.m.) Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Changes --- Addressed James' comment. Bugs: MESOS-8787 https://issues.apache.org/jira/browse/MESOS-8787 Repository: mesos Description --- Marked volume/block creation and destroy operations as experimental. Diffs (updated) - include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 Diff: https://reviews.apache.org/r/66616/diff/2/ Changes: https://reviews.apache.org/r/66616/diff/1-2/ Testing --- No need for testing since only comments are changed. Thanks, Chun-Hung Hsiao
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
> On April 13, 2018, 6:39 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['66616']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66616 > > > > Relevant logs: > > > > - > > [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66616/logs/mesos-tests-cmake-stdout.log): > > > > ``` > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): > > warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss > > of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): > > warning C4090: 'function': different 'const' qualifiers > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): > > warning C4716: 'pthread_cond_broadcast': must return a value > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): > > warning C4716: 'pthread_cond_wait': must return a value > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): > > warning C4996: 'fopen': This function or variable may be unsafe. Consider > > using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. > > See online help for details. > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): > > warning C4267: 'initializing': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): > > warning C4267: 'function': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): > > warning C4267: 'initializing': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): > > warning C4267: 'function': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): > > warning C4267: 'function': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): > > warning C4267: 'function': conversion from 'size_t' to 'int', possible > > loss of data > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): > > warning C4996: 'strcpy': This function or variable may be unsafe. Consider > > using strcpy_s instead. To disable deprecation, use > > _CRT_SECURE_NO_WARNINGS. See online help for details. > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] > > > > d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): > > warning C4996: 'fopen': This function or variable may be unsafe. Consider > > using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. > > See online help for details. > > [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/#review201161 --- Should we also mark the message type declarations as "experimental", for clarity? e.g. `CreateVolume` - James DeFelice On April 14, 2018, 1:06 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66616/ > --- > > (Updated April 14, 2018, 1:06 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8787 > https://issues.apache.org/jira/browse/MESOS-8787 > > > Repository: mesos > > > Description > --- > > Marked volume/block creation and destroy operations as experimental. > > > Diffs > - > > include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 > include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 > > > Diff: https://reviews.apache.org/r/66616/diff/1/ > > > Testing > --- > > No need for testing since only comments are changed. > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/#review201159 --- Patch looks great! Reviews applied: [66398, 66407, 66408, 66409, 66410, 66411, 66418, 66574, 66575, 66576, 66616] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 14, 2018, 1:06 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66616/ > --- > > (Updated April 14, 2018, 1:06 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8787 > https://issues.apache.org/jira/browse/MESOS-8787 > > > Repository: mesos > > > Description > --- > > Marked volume/block creation and destroy operations as experimental. > > > Diffs > - > > include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 > include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 > > > Diff: https://reviews.apache.org/r/66616/diff/1/ > > > Testing > --- > > No need for testing since only comments are changed. > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/#review201152 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66616']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66616 Relevant logs: - [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66616/logs/mesos-tests-cmake-stdout.log): ``` d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy
Review Request 66616: Marked volume/block creation and destroy operations as experimental.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs: MESOS-8787 https://issues.apache.org/jira/browse/MESOS-8787 Repository: mesos Description --- Marked volume/block creation and destroy operations as experimental. Diffs - include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 Diff: https://reviews.apache.org/r/66616/diff/1/ Testing --- No need for testing since only comments are changed. Thanks, Chun-Hung Hsiao
