Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-06-06 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/#review204408
---



Patch looks great!

Reviews applied: [66559, 66650, 66651, 66561, 66562, 66652]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 6, 2018, 8:44 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66652/
> ---
> 
> (Updated June 6, 2018, 8:44 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed local_puller to image_tar_puller.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f86884de2beb946c8bfc2bb8260e09a9c98ce625 
>   src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 509be63635e21e48a62deaf7c545575d2d8221b3 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> d7d8987d493a37d20f32ddd254dc0c3b15159951 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3cb1a7ed251cf22c8609b39685da2d86b2770766 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> b703b827a9a00b1c335cd1773c4d3e048eb16d66 
> 
> 
> Diff: https://reviews.apache.org/r/66652/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-06-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/#review204372
---



PASS: Mesos patch 66652 was successfully built and tested.

Reviews applied: `['66559', '66650', '66651', '66561', '66562', '66652']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66652

- Mesos Reviewbot Windows


On June 6, 2018, 8:44 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66652/
> ---
> 
> (Updated June 6, 2018, 8:44 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed local_puller to image_tar_puller.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f86884de2beb946c8bfc2bb8260e09a9c98ce625 
>   src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 509be63635e21e48a62deaf7c545575d2d8221b3 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> d7d8987d493a37d20f32ddd254dc0c3b15159951 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3cb1a7ed251cf22c8609b39685da2d86b2770766 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> b703b827a9a00b1c335cd1773c4d3e048eb16d66 
> 
> 
> Diff: https://reviews.apache.org/r/66652/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-06-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/
---

(Updated June 6, 2018, 1:44 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
---

Renamed local_puller to image_tar_puller.


Diffs (updated)
-

  src/CMakeLists.txt f86884de2beb946c8bfc2bb8260e09a9c98ce625 
  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
509be63635e21e48a62deaf7c545575d2d8221b3 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
d7d8987d493a37d20f32ddd254dc0c3b15159951 
  src/tests/containerizer/provisioner_docker_tests.cpp 
3cb1a7ed251cf22c8609b39685da2d86b2770766 
  src/tests/containerizer/runtime_isolator_tests.cpp 
b703b827a9a00b1c335cd1773c4d3e048eb16d66 


Diff: https://reviews.apache.org/r/66652/diff/2/

Changes: https://reviews.apache.org/r/66652/diff/1-2/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-04-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/#review201421
---


Fix it, then Ship it!





src/tests/containerizer/runtime_isolator_tests.cpp
Lines 178-181 (original), 178-181 (patched)


I think we can merge these 4 lines of code into 3 lines.


- Qian Zhang


On April 17, 2018, 1:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66652/
> ---
> 
> (Updated April 17, 2018, 1:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed local_puller to image_tar_puller.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> d7d8987d493a37d20f32ddd254dc0c3b15159951 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> b703b827a9a00b1c335cd1773c4d3e048eb16d66 
> 
> 
> Diff: https://reviews.apache.org/r/66652/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-04-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/#review201329
---



Patch looks great!

Reviews applied: [66559, 66650, 66651, 66561, 66562, 66652]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 16, 2018, 10:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66652/
> ---
> 
> (Updated April 16, 2018, 10:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed local_puller to image_tar_puller.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> d7d8987d493a37d20f32ddd254dc0c3b15159951 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> b703b827a9a00b1c335cd1773c4d3e048eb16d66 
> 
> 
> Diff: https://reviews.apache.org/r/66652/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

2018-04-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/#review201294
---



PASS: Mesos patch 66652 was successfully built and tested.

Reviews applied: `['66559', '66650', '66651', '66561', '66562', '66652']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66652

- Mesos Reviewbot Windows


On April 17, 2018, 5:32 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66652/
> ---
> 
> (Updated April 17, 2018, 5:32 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed local_puller to image_tar_puller.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> d7d8987d493a37d20f32ddd254dc0c3b15159951 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
>   src/tests/containerizer/runtime_isolator_tests.cpp 
> b703b827a9a00b1c335cd1773c4d3e048eb16d66 
> 
> 
> Diff: https://reviews.apache.org/r/66652/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 66652: Renamed local_puller to image_tar_puller.

2018-04-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66652/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
---

Renamed local_puller to image_tar_puller.


Diffs
-

  src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
d7d8987d493a37d20f32ddd254dc0c3b15159951 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c664ff807583d587d94b0ab797330d5d3daf7657 
  src/tests/containerizer/runtime_isolator_tests.cpp 
b703b827a9a00b1c335cd1773c4d3e048eb16d66 


Diff: https://reviews.apache.org/r/66652/diff/1/


Testing
---


Thanks,

Gilbert Song