Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review209258 --- PASS: Mesos patch 66657 was successfully built and tested. Reviews applied: `['66657']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2424/mesos-review-66657 - Mesos Reviewbot Windows On Oct. 5, 2018, 9:40 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66657/ > --- > > (Updated Oct. 5, 2018, 9:40 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8779 > https://issues.apache.org/jira/browse/MESOS-8779 > > > Repository: mesos > > > Description > --- > > Creates an empty configuration file if it does not exist instead > of throwing an error due to the missing file `config.toml`. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > c88952b9f87f1cf558d7aef44803d7a24873d8bf > > > Diff: https://reviews.apache.org/r/66657/diff/2/ > > > Testing > --- > > Removed `~/.mesos/config.toml` and ran `mesos config show`. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/ --- (Updated Oct. 5, 2018, 11:40 a.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-8779 https://issues.apache.org/jira/browse/MESOS-8779 Repository: mesos Description --- Creates an empty configuration file if it does not exist instead of throwing an error due to the missing file `config.toml`. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf Diff: https://reviews.apache.org/r/66657/diff/2/ Changes: https://reviews.apache.org/r/66657/diff/1-2/ Testing --- Removed `~/.mesos/config.toml` and ran `mesos config show`. Thanks, Armand Grillet
Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review201363 --- Patch looks great! Reviews applied: [66657] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 17, 2018, 9:43 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66657/ > --- > > (Updated April 17, 2018, 9:43 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8779 > https://issues.apache.org/jira/browse/MESOS-8779 > > > Repository: mesos > > > Description > --- > > Creates an empty configuration file if it does not exist instead > of throwing an error due to the missing file `config.toml`. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > 6f92622725d8a042a2a728fd38c977ac690ef6be > > > Diff: https://reviews.apache.org/r/66657/diff/1/ > > > Testing > --- > > Removed `~/.mesos/config.toml` and ran `mesos config show`. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review201308 --- PASS: Mesos patch 66657 was successfully built and tested. Reviews applied: `['66657']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66657 - Mesos Reviewbot Windows On April 17, 2018, 9:43 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66657/ > --- > > (Updated April 17, 2018, 9:43 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8779 > https://issues.apache.org/jira/browse/MESOS-8779 > > > Repository: mesos > > > Description > --- > > Creates an empty configuration file if it does not exist instead > of throwing an error due to the missing file `config.toml`. > > > Diffs > - > > src/python/cli_new/lib/cli/config.py > 6f92622725d8a042a2a728fd38c977ac690ef6be > > > Diff: https://reviews.apache.org/r/66657/diff/1/ > > > Testing > --- > > Removed `~/.mesos/config.toml` and ran `mesos config show`. > > > Thanks, > > Armand Grillet > >
Review Request 66657: Updated Config initialization for new CLI if file does not exist.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8779 https://issues.apache.org/jira/browse/MESOS-8779 Repository: mesos Description --- Creates an empty configuration file if it does not exist instead of throwing an error due to the missing file `config.toml`. Diffs - src/python/cli_new/lib/cli/config.py 6f92622725d8a042a2a728fd38c977ac690ef6be Diff: https://reviews.apache.org/r/66657/diff/1/ Testing --- Removed `~/.mesos/config.toml` and ran `mesos config show`. Thanks, Armand Grillet
