Re: Review Request 66671: Updated composing containerizer tests. (WIP)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201382 --- Patch looks great! Reviews applied: [8, 9, 66670, 66671] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 17, 2018, 3:23 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66671/ > --- > > (Updated April 17, 2018, 3:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8737 > https://issues.apache.org/jira/browse/MESOS-8737 > > > Repository: mesos > > > Description > --- > > This patch updates composing containerizer tests in order to be > consistent with the unification of `destroy()` and `wait()` return > types. > > > Diffs > - > > src/tests/containerizer/composing_containerizer_tests.cpp > 6964ac2f050396a733b04e650e59d6c29c59665d > > > Diff: https://reviews.apache.org/r/66671/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 66671: Updated composing containerizer tests. (WIP)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201327 --- PASS: Mesos patch 66671 was successfully built and tested. Reviews applied: `['8', '9', '66670', '66671']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66671 - Mesos Reviewbot Windows On April 17, 2018, 8:23 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66671/ > --- > > (Updated April 17, 2018, 8:23 a.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8737 > https://issues.apache.org/jira/browse/MESOS-8737 > > > Repository: mesos > > > Description > --- > > This patch updates composing containerizer tests in order to be > consistent with the unification of `destroy()` and `wait()` return > types. > > > Diffs > - > > src/tests/containerizer/composing_containerizer_tests.cpp > 6964ac2f050396a733b04e650e59d6c29c59665d > > > Diff: https://reviews.apache.org/r/66671/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Review Request 66671: Updated composing containerizer tests. (WIP)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang. Bugs: MESOS-8737 https://issues.apache.org/jira/browse/MESOS-8737 Repository: mesos Description --- This patch updates composing containerizer tests in order to be consistent with the unification of `destroy()` and `wait()` return types. Diffs - src/tests/containerizer/composing_containerizer_tests.cpp 6964ac2f050396a733b04e650e59d6c29c59665d Diff: https://reviews.apache.org/r/66671/diff/1/ Testing --- internal CI Thanks, Andrei Budnik
