Re: Review Request 67380: Replaced raw string literals with escaped C-style string literals.

2018-05-30 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67380/#review204041
---



PASS: Mesos patch 67380 was successfully built and tested.

Reviews applied: `['67380']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67380

- Mesos Reviewbot Windows


On May 30, 2018, 9:58 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67380/
> ---
> 
> (Updated May 30, 2018, 9:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some versions of GCC, e.g., the default version on ubuntu-14.04,
> failed to parse the raw string literals used here.
> 
> This patch replaces them with escaped string literals.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67380/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` failed to compile w/o this patch on a ubuntu-14.04 setup, 
> succeeds with the patch
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 67380: Replaced raw string literals with escaped C-style string literals.

2018-05-30 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67380/
---

Review request for mesos, Alexander Rukletsov and James Peach.


Repository: mesos


Description
---

Some versions of GCC, e.g., the default version on ubuntu-14.04,
failed to parse the raw string literals used here.

This patch replaces them with escaped string literals.


Diffs
-

  src/tests/containerizer/linux_devices_isolator_tests.cpp 
efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 


Diff: https://reviews.apache.org/r/67380/diff/1/


Testing
---

`make check` failed to compile w/o this patch on a ubuntu-14.04 setup, succeeds 
with the patch


Thanks,

Benjamin Bannier