Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-08-16 Thread Dragos Schebesch via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---

(Updated Aug. 16, 2018, 6:52 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
---

Refactored ReviewBoard API functionality into separate module.


Diffs (updated)
-

  support/python3/common.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67502/diff/6/

Changes: https://reviews.apache.org/r/67502/diff/5-6/


Testing
---

For example, to call the api on a specific review_url, with some data, we would 
use the following code:

```
ReviewBoardHandler().api(review_url, data)
```


Thanks,

Dragos Schebesch

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-08-14 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review207241
---


Fix it, then Ship it!





support/python3/common.py
Lines 153-154 (patched)


I actually disagree with the TODO here: we often use an empty diff (but a 
new iteration of the review) to purposefully trigger the Review Bot.


- Andrew Schwartzmeyer


On Aug. 7, 2018, 10:36 a.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> ---
> 
> (Updated Aug. 7, 2018, 10:36 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored ReviewBoard API functionality into separate module.
> 
> 
> Diffs
> -
> 
>   support/python3/common.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67502/diff/5/
> 
> 
> Testing
> ---
> 
> For example, to call the api on a specific review_url, with some data, we 
> would use the following code:
> 
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-08-07 Thread Dragos Schebesch via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---

(Updated Aug. 7, 2018, 5:36 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Refactored ReviewBoard API functionality into separate module.


Diffs (updated)
-

  support/python3/common.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67502/diff/5/

Changes: https://reviews.apache.org/r/67502/diff/4-5/


Testing
---

For example, to call the api on a specific review_url, with some data, we would 
use the following code:

```
ReviewBoardHandler().api(review_url, data)
```


Thanks,

Dragos Schebesch

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-08-06 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206908
---




support/python3/common.py
Lines 146 (patched)


Pylint complains that there are too many local variables, you can remove 
`latest_diff_url` to have only 15 vars in the file.


- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> ---
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored API functionality into separate module -- this was done to clean 
> up the codebase and put all API calls in single place.
> 
> 
> Diffs
> -
> 
>   support/python3/common.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67502/diff/4/
> 
> 
> Testing
> ---
> 
> For example, to call the api on a specific review_url, with some data, we 
> would use the following code:
> 
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-07-24 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206381
---


Ship it!




Ship It!

- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> ---
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored API functionality into separate module -- this was done to clean 
> up the codebase and put all API calls in single place.
> 
> 
> Diffs
> -
> 
>   support/python3/common.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67502/diff/4/
> 
> 
> Testing
> ---
> 
> For example, to call the api on a specific review_url, with some data, we 
> would use the following code:
> 
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-07-19 Thread Dragos Schebesch via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---

(Updated July 19, 2018, 3:48 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Refactored API functionality into separate module -- this was done to clean up 
the codebase and put all API calls in single place.


Diffs
-

  support/python3/common.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67502/diff/4/


Testing
---

For example, to call the api on a specific review_url, with some data, we would 
use the following code:

```
ReviewBoardHandler().api(review_url, data)
```


Thanks,

Dragos Schebesch

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-07-18 Thread Dragos Schebesch via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---

(Updated July 18, 2018, 8:50 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Summary (updated)
-

Refactored ReviewBoard API functionality into separate module.


Repository: mesos


Description (updated)
---

Refactored ReviewBoard API functionality into separate module.


Diffs (updated)
-

  support/python3/common.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67502/diff/4/

Changes: https://reviews.apache.org/r/67502/diff/3-4/


Testing (updated)
---

For example, to call the api on a specific review_url, with some data, we would 
use the following code:

```
ReviewBoardHandler().api(review_url, data)
```


Thanks,

Dragos Schebesch