Re: Review Request 67503: Added support helper for fetching review ids.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review207242
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Aug. 7, 2018, 10:36 a.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> ---
> 
> (Updated Aug. 7, 2018, 10:36 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support helper for fetching review ids.
> 
> 
> Diffs
> -
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/5/
> 
> 
> Testing
> ---
> 
> Sample run on this review request id:
> ```
> ./get-review-ids.py -r 67503
> Dependent review: https://reviews.apache.org/api/review-requests/67502/
> 67502
> 
> 67503
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67503: Added support helper for fetching review ids.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
---

(Updated Aug. 7, 2018, 5:36 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Added support helper for fetching review ids.


Diffs (updated)
-

  support/python3/get-review-ids.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67503/diff/5/

Changes: https://reviews.apache.org/r/67503/diff/4-5/


Testing
---

Sample run on this review request id:
```
./get-review-ids.py -r 67503
Dependent review: https://reviews.apache.org/api/review-requests/67502/
67502

67503
```


Thanks,

Dragos Schebesch

Re: Review Request 67503: Added support helper for fetching review ids.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review206382
---


Fix it, then Ship it!




LGTM except the first line. FYI the commit header and message should contain no 
line that are more than 72 characters.


support/python3/get-review-ids.py
Lines 1 (patched)


Should be `python3`.


- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> ---
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper for fetching review id, which is needed to decouple this logic 
> from verify-reviews.py. We need this for the windows build so we can trigger 
> a downstream job for each review request on another server.
> 
> 
> Diffs
> -
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/4/
> 
> 
> Testing
> ---
> 
> Sample run on this review request id:
> ```
> ./get-review-ids.py -r 67503
> Dependent review: https://reviews.apache.org/api/review-requests/67502/
> 67502
> 
> 67503
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67503: Added support helper for fetching review ids.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
---

(Updated July 19, 2018, 3:48 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Added helper for fetching review id, which is needed to decouple this logic 
from verify-reviews.py. We need this for the windows build so we can trigger a 
downstream job for each review request on another server.


Diffs
-

  support/python3/get-review-ids.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67503/diff/4/


Testing
---

Sample run on this review request id:
```
./get-review-ids.py -r 67503
Dependent review: https://reviews.apache.org/api/review-requests/67502/
67502

67503
```


Thanks,

Dragos Schebesch

Re: Review Request 67503: Added support helper for fetching review ids.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
---

(Updated July 18, 2018, 8:50 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Summary (updated)
-

Added support helper for fetching review ids.


Repository: mesos


Description (updated)
---

Added support helper for fetching review ids.


Diffs (updated)
-

  support/python3/get-review-ids.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67503/diff/4/

Changes: https://reviews.apache.org/r/67503/diff/3-4/


Testing (updated)
---

Sample run on this review request id:
```
./get-review-ids.py -r 67503
Dependent review: https://reviews.apache.org/api/review-requests/67502/
67502

67503
```


Thanks,

Dragos Schebesch