Re: Review Request 67878: Added/updated tests to check per-framework metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 24, 2018, 8:03 p.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. Changes --- Tested functionality of 'suppressed' metrics. Repository: mesos Description --- Added/updated tests to check per-framework metrics. Diffs (updated) - src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 src/tests/scheduler_tests.cpp bcdd0ec010889b4155a0feebe0248b7593d8bf0c Diff: https://reviews.apache.org/r/67878/diff/4/ Changes: https://reviews.apache.org/r/67878/diff/3-4/ Testing --- Thanks, Greg Mann
Re: Review Request 67878: Added/updated tests to check per-framework metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 24, 2018, 3:44 p.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. Repository: mesos Description --- Added/updated tests to check per-framework metrics. Diffs (updated) - src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 Diff: https://reviews.apache.org/r/67878/diff/3/ Changes: https://reviews.apache.org/r/67878/diff/2-3/ Testing --- Thanks, Greg Mann
Re: Review Request 67878: Added/updated tests to check per-framework metrics.
> On July 19, 2018, 3:45 p.m., Gastón Kleiman wrote: > > Can you add a test that verifies whether allocator and non-allocator > > per-framework metrics are evicted once the `max_completed_frameworks` bound > > is reached? And also one testing the `suppressed` metric. - Gastón --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/#review206251 --- On July 17, 2018, 6:46 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67878/ > --- > > (Updated July 17, 2018, 6:46 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. > > > Repository: mesos > > > Description > --- > > Added/updated tests to check per-framework metrics. > > > Diffs > - > > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > > > Diff: https://reviews.apache.org/r/67878/diff/2/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
Re: Review Request 67878: Added/updated tests to check per-framework metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/#review206251 --- Can you add a test that verifies whether allocator and non-allocator per-framework metrics are evicted once the `max_completed_frameworks` bound is reached? - Gastón Kleiman On July 17, 2018, 6:46 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67878/ > --- > > (Updated July 17, 2018, 6:46 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. > > > Repository: mesos > > > Description > --- > > Added/updated tests to check per-framework metrics. > > > Diffs > - > > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > > > Diff: https://reviews.apache.org/r/67878/diff/2/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
Re: Review Request 67878: Added/updated tests to check per-framework metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 18, 2018, 1:46 a.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. Changes --- Removed the filter metric test. Repository: mesos Description --- Added/updated tests to check per-framework metrics. Diffs (updated) - src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb Diff: https://reviews.apache.org/r/67878/diff/2/ Changes: https://reviews.apache.org/r/67878/diff/1-2/ Testing --- Thanks, Greg Mann
Review Request 67878: Added/updated tests to check per-framework metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. Repository: mesos Description --- Added/updated tests to check per-framework metrics. Diffs - src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb Diff: https://reviews.apache.org/r/67878/diff/1/ Testing --- Thanks, Greg Mann
