Re: Review Request 67956: Removed some generic flag parsers that are now in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67956/#review210340 --- Ship it! Ship It! - Benjamin Mahler On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67956/ > --- > > (Updated July 18, 2018, 1:19 a.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Removed some generic flag parsers that are now in stout. > > > Diffs > - > > src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 > > > Diff: https://reviews.apache.org/r/67956/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Hindman > >
Re: Review Request 67956: Removed some generic flag parsers that are now in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67956/#review206247 --- Ship it! I assume removing these in this commit seprate from adding them to stout in the previous commit didn't cause build errors, for the short time between commits when there were duplicate definitions of them? - Kevin Klues On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67956/ > --- > > (Updated July 18, 2018, 1:19 a.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Removed some generic flag parsers that are now in stout. > > > Diffs > - > > src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 > > > Diff: https://reviews.apache.org/r/67956/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Hindman > >
Review Request 67956: Removed some generic flag parsers that are now in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67956/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Removed some generic flag parsers that are now in stout. Diffs - src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 Diff: https://reviews.apache.org/r/67956/diff/1/ Testing --- make check Thanks, Benjamin Hindman
