Re: Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/#review206354 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:44 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67977/ > --- > > (Updated July 19, 2018, 8:44 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > Liangyu Zhao, and Radhika Jandhyala. > > > Bugs: MESOS-5941 and MESOS-9097 > https://issues.apache.org/jira/browse/MESOS-5941 > https://issues.apache.org/jira/browse/MESOS-9097 > > > Repository: mesos > > > Description > --- > > Several problems existed on Windows here: > > * The `BUILD_DIR` path has forward slashes (probably fine, but wrong). > * The executable must be named correctly, `.exe` and all. > * We should assert that `test-linkee` exists. > * The shell should not be used, otherwise `'(62)'` will resolve to an > unknown UPID inside `test-linkee` because of the single quotes. > > > Diffs > - > > 3rdparty/libprocess/src/tests/process_tests.cpp > 8baf60d8bbb675e26fea5e76c825ef73fedbc629 > > > Diff: https://reviews.apache.org/r/67977/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/#review206249 --- Ship it! Ship It! - Radhika Jandhyala On July 19, 2018, 8:44 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67977/ > --- > > (Updated July 19, 2018, 8:44 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > Liangyu Zhao, and Radhika Jandhyala. > > > Bugs: MESOS-5941 and MESOS-9097 > https://issues.apache.org/jira/browse/MESOS-5941 > https://issues.apache.org/jira/browse/MESOS-9097 > > > Repository: mesos > > > Description > --- > > Several problems existed on Windows here: > > * The `BUILD_DIR` path has forward slashes (probably fine, but wrong). > * The executable must be named correctly, `.exe` and all. > * We should assert that `test-linkee` exists. > * The shell should not be used, otherwise `'(62)'` will resolve to an > unknown UPID inside `test-linkee` because of the single quotes. > > > Diffs > - > > 3rdparty/libprocess/src/tests/process_tests.cpp > 8baf60d8bbb675e26fea5e76c825ef73fedbc629 > > > Diff: https://reviews.apache.org/r/67977/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala. Bugs: MESOS-5941 and MESOS-9097 https://issues.apache.org/jira/browse/MESOS-5941 https://issues.apache.org/jira/browse/MESOS-9097 Repository: mesos Description --- Several problems existed on Windows here: * The `BUILD_DIR` path has forward slashes (probably fine, but wrong). * The executable must be named correctly, `.exe` and all. * We should assert that `test-linkee` exists. * The shell should not be used, otherwise `'(62)'` will resolve to an unknown UPID inside `test-linkee` because of the single quotes. Diffs - 3rdparty/libprocess/src/tests/process_tests.cpp 8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67977/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
