Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review208108 --- Ship it! Ship It! - Jie Yu On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67984/ > --- > > (Updated Aug. 6, 2018, 6:46 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, > Jie Yu, Joseph Wu, and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Windows: Added CMake logic to download and "install" `wclayer.exe`. > > > Diffs > - > > 3rdparty/CMakeLists.txt 8a69685e4713a9c8355a5c3f2f10aedc737f453b > src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c > > > Diff: https://reviews.apache.org/r/67984/diff/5/ > > > Testing > --- > > > Thanks, > > Liangyu Zhao > >
Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review206694 --- Ship it! I'll make sure this gets committed with original authorship (me); I thought RB would preserve it, but apparently not, I guess it takes it from the user submitting. Oh well. - Andrew Schwartzmeyer On July 31, 2018, 2:42 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67984/ > --- > > (Updated July 31, 2018, 2:42 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added CMake logic to download and "install" `wclayer.exe`. > > > Diffs > - > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c > > > Diff: https://reviews.apache.org/r/67984/diff/2/ > > > Testing > --- > > > Thanks, > > Liangyu Zhao > >
Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/ --- (Updated July 31, 2018, 9:42 p.m.) Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. Repository: mesos Description --- Windows: Added CMake logic to download and "install" `wclayer.exe`. Diffs (updated) - 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c Diff: https://reviews.apache.org/r/67984/diff/2/ Changes: https://reviews.apache.org/r/67984/diff/1-2/ Testing --- Thanks, Liangyu Zhao
Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review206256 --- Bad review! Error: Circular dependency detected for review 67931. Please fix the 'depends_on' field. - Mesos Reviewbot Windows On July 19, 2018, 5:07 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67984/ > --- > > (Updated July 19, 2018, 5:07 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added CMake logic to download and "install" `wclayer.exe`. > > > Diffs > - > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c > > > Diff: https://reviews.apache.org/r/67984/diff/1/ > > > Testing > --- > > > Thanks, > > Liangyu Zhao > >
Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/ --- Review request for mesos. Repository: mesos Description --- Windows: Added CMake logic to download and "install" `wclayer.exe`. Diffs - 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c Diff: https://reviews.apache.org/r/67984/diff/1/ Testing --- Thanks, Liangyu Zhao
