Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68303/#review207099
---



PASS: Mesos patch 68303 was successfully built and tested.

Reviews applied: `['68303']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2133/mesos-review-68303

- Mesos Reviewbot Windows


On Aug. 10, 2018, 10:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68303/
> ---
> 
> (Updated Aug. 10, 2018, 10:17 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9149
> https://issues.apache.org/jira/browse/MESOS-9149
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed gRPC compilation for non-SSL build.
> 
> 
> Diffs
> -
> 
>   3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc 
>   3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 
> 
> 
> Diff: https://reviews.apache.org/r/68303/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on a fresh Ubuntu 16.04 box.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68303/#review207098
---


Ship it!




Tested with `libssl-dev` uninstalled; repro'ed without, built with. Thanks!

- Andrew Schwartzmeyer


On Aug. 10, 2018, 3:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68303/
> ---
> 
> (Updated Aug. 10, 2018, 3:17 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9149
> https://issues.apache.org/jira/browse/MESOS-9149
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed gRPC compilation for non-SSL build.
> 
> 
> Diffs
> -
> 
>   3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc 
>   3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 
> 
> 
> Diff: https://reviews.apache.org/r/68303/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on a fresh Ubuntu 16.04 box.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68303/
---

Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Bugs: MESOS-9149
https://issues.apache.org/jira/browse/MESOS-9149


Repository: mesos


Description
---

Fixed gRPC compilation for non-SSL build.


Diffs
-

  3rdparty/grpc-1.10.0.patch 98ae6af2b82dbad42cabf7f19dbbb3539c2dd6dc 
  3rdparty/grpc.md 8d0e189e0d7a212e5ebd73f53adceb26457735e8 


Diff: https://reviews.apache.org/r/68303/diff/1/


Testing
---

`make check` on a fresh Ubuntu 16.04 box.


Thanks,

Chun-Hung Hsiao