Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-24 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 24, 2018, 11:46 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/11/

Changes: https://reviews.apache.org/r/68953/diff/10-11/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-24 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 24, 2018, 11:08 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/10/

Changes: https://reviews.apache.org/r/68953/diff/9-10/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-24 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 24, 2018, 10:17 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/9/

Changes: https://reviews.apache.org/r/68953/diff/8-9/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-24 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 24, 2018, 9:38 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/8/

Changes: https://reviews.apache.org/r/68953/diff/7-8/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-24 Thread Jacob Janco 


> On Oct. 24, 2018, 2:51 a.m., Greg Mann wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 188 (patched)
> > 
> >
> > Nit: indented too far.

Fixed.


> On Oct. 24, 2018, 2:51 a.m., Greg Mann wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 189 (patched)
> > 
> >
> > Is the `Some()` here really necessary?

Nope.


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209944
---


On Oct. 24, 2018, 9:38 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 24, 2018, 9:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There has been a proliferation of configuration
> passed into the allocator. This commit collects
> that configuration into an `Options` struct.
> Test fixes have been added as well.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
>   src/master/allocator/mesos/hierarchical.cpp 
> c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
>   src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
>   src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
>   src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
>   src/tests/hierarchical_allocator_benchmarks.cpp 
> bf9167b63747f7b8a402d950947028436307082a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
>   src/tests/master_allocator_tests.cpp 
> 88288ae8528900b017941db9b07f5f83649fa096 
>   src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
>   src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
>   src/tests/resource_offers_tests.cpp 
> 24800c2aa291431e4865e4104da62054b14e5eca 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/8/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-23 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209944
---


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp
Lines 188 (patched)


Nit: indented too far.



src/tests/hierarchical_allocator_tests.cpp
Lines 189 (patched)


Is the `Some()` here really necessary?


- Greg Mann


On Oct. 22, 2018, 11:52 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 22, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There has been a proliferation of configuration
> passed into the allocator. This commit collects
> that configuration into an `Options` struct.
> Test fixes have been added as well.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
>   src/master/allocator/mesos/hierarchical.cpp 
> c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
>   src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
>   src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
>   src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
>   src/tests/hierarchical_allocator_benchmarks.cpp 
> bf9167b63747f7b8a402d950947028436307082a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
>   src/tests/master_allocator_tests.cpp 
> 88288ae8528900b017941db9b07f5f83649fa096 
>   src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
>   src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
>   src/tests/resource_offers_tests.cpp 
> 24800c2aa291431e4865e4104da62054b14e5eca 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/7/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-22 Thread Jacob Janco 


> On Oct. 22, 2018, 3:44 a.m., Greg Mann wrote:
> > include/mesos/allocator/allocator.hpp
> > Lines 55 (patched)
> > 
> >
> > Is this necessary in this patch, or should it be added in the child 
> > patch which adds the flag?

I like that, I'll fold it into the child.


> On Oct. 22, 2018, 3:44 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 763-764 (patched)
> > 
> >
> > Fits on one line.

Fixed.


> On Oct. 22, 2018, 3:44 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 766-767 (patched)
> > 
> >
> > Fits on one line.

Fixed


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209838
---


On Oct. 22, 2018, 11:52 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 22, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There has been a proliferation of configuration
> passed into the allocator. This commit collects
> that configuration into an `Options` struct.
> Test fixes have been added as well.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
>   src/master/allocator/mesos/hierarchical.cpp 
> c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
>   src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
>   src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
>   src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
>   src/tests/hierarchical_allocator_benchmarks.cpp 
> bf9167b63747f7b8a402d950947028436307082a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
>   src/tests/master_allocator_tests.cpp 
> 88288ae8528900b017941db9b07f5f83649fa096 
>   src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
>   src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
>   src/tests/resource_offers_tests.cpp 
> 24800c2aa291431e4865e4104da62054b14e5eca 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/7/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-22 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 22, 2018, 11:52 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/7/

Changes: https://reviews.apache.org/r/68953/diff/6-7/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-21 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209838
---




include/mesos/allocator/allocator.hpp
Lines 55 (patched)


Is this necessary in this patch, or should it be added in the child patch 
which adds the flag?



src/master/master.cpp
Lines 763-764 (patched)


Fits on one line.



src/master/master.cpp
Lines 766-767 (patched)


Fits on one line.


- Greg Mann


On Oct. 18, 2018, 10:59 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 18, 2018, 10:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There has been a proliferation of configuration
> passed into the allocator. This commit collects
> that configuration into an `Options` struct.
> Test fixes have been added as well.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> 7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
>   src/master/allocator/mesos/hierarchical.cpp 
> c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
>   src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
>   src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
>   src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
>   src/tests/hierarchical_allocator_benchmarks.cpp 
> bf9167b63747f7b8a402d950947028436307082a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
>   src/tests/master_allocator_tests.cpp 
> 88288ae8528900b017941db9b07f5f83649fa096 
>   src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
>   src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
>   src/tests/resource_offers_tests.cpp 
> 24800c2aa291431e4865e4104da62054b14e5eca 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/6/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-18 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 18, 2018, 10:59 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp 
c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/6/

Changes: https://reviews.apache.org/r/68953/diff/5-6/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-17 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 17, 2018, 10:19 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp a89574afa8652f86404e8b71ae002c3bc7f83c34 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/5/

Changes: https://reviews.apache.org/r/68953/diff/4-5/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-11 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 11, 2018, 11:17 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description (updated)
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp 
bf9167b63747f7b8a402d950947028436307082a 
  src/tests/hierarchical_allocator_tests.cpp 
27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp a89574afa8652f86404e8b71ae002c3bc7f83c34 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/4/

Changes: https://reviews.apache.org/r/68953/diff/3-4/


Testing
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-11 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 11, 2018, 11:13 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Changes
---

fixes from jpeach's review


Summary (updated)
-

Refactor allocator configuration into a struct.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description (updated)
---

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 


Diff: https://reviews.apache.org/r/68953/diff/3/

Changes: https://reviews.apache.org/r/68953/diff/2-3/


Testing
---

make check on OSX


Thanks,

Jacob Janco