Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-20 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/#review210747
---


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 19, 2018, 10:12 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69359/
> ---
> 
> (Updated Nov. 19, 2018, 10:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the `ReconcileDroppedOperation` test relies on converting
> preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
> this test is rewritten to create two disks from a storage pool, with one
> operation dropped.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 077a46585bd56181ba199dc529e09f38f4971338 
> 
> 
> Diff: https://reviews.apache.org/r/69359/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/
---

(Updated Nov. 19, 2018, 9:12 p.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
---

Addressed Benjamin's comments.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

Previously the `ReconcileDroppedOperation` test relies on converting
preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
this test is rewritten to create two disks from a storage pool, with one
operation dropped.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
077a46585bd56181ba199dc529e09f38f4971338 


Diff: https://reviews.apache.org/r/69359/diff/2/

Changes: https://reviews.apache.org/r/69359/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-19 Thread Chun-Hung Hsiao 


> On Nov. 16, 2018, 12:02 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 3899 (original), 3895 (patched)
> > 
> >
> > Before dereferencing `begin` we should `ASSERT_FALSE(raw.empty())`.

`ASSERT_SOME_EQ(Gigabytes(4), raw.disk())` alrealy guarantees that `raw` is not 
empty. But let me do a `ASSERT_EQ(1u, offersBeforeOperations->size())` to make 
sure that the offer contains raw disk resources.


> On Nov. 16, 2018, 12:02 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3899 (patched)
> > 
> >
> > Let's check before dereferencing `begin()` that `raw - source1` is not 
> > empty.

`ASSERT_SOME_EQ(Gigabytes(4), raw.disk())` would have guaranteed this. I prefer 
dropping this to keep the test succinct, unless you strongly prefer adding the 
extra check.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/#review210604
---


On Nov. 16, 2018, midnight, Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69359/
> ---
> 
> (Updated Nov. 16, 2018, midnight)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the `ReconcileDroppedOperation` test relies on converting
> preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
> this test is rewritten to create two disks from a storage pool, with one
> operation dropped.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 077a46585bd56181ba199dc529e09f38f4971338 
> 
> 
> Diff: https://reviews.apache.org/r/69359/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/#review210604
---



Please move these test fixes to the patches causing the failures so we can 
avoid introducing broken states in the history (useful for e.g., `git-bisect`).


src/tests/storage_local_resource_provider_tests.cpp
Line 3899 (original), 3895 (patched)


Before dereferencing `begin` we should `ASSERT_FALSE(raw.empty())`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3898 (patched)


Let's us a `static_cast` since this is C++.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3899 (patched)


Let's check before dereferencing `begin()` that `raw - source1` is not 
empty.



src/tests/storage_local_resource_provider_tests.cpp
Line 3965 (original), 3972 (patched)


nit: If we'd break the line after `EXPECT_CALL(` all args would fit on a 
single line.


- Benjamin Bannier


On Nov. 16, 2018, 1 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69359/
> ---
> 
> (Updated Nov. 16, 2018, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the `ReconcileDroppedOperation` test relies on converting
> preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
> this test is rewritten to create two disks from a storage pool, with one
> operation dropped.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 077a46585bd56181ba199dc529e09f38f4971338 
> 
> 
> Diff: https://reviews.apache.org/r/69359/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/#review210588
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69036', '69356', '69357', '69359']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2605/mesos-review-69359

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2605/mesos-review-69359/logs/mesos-tests.log):

```
I1116 01:02:18.408365 35608 master.cpp:1273] Agent 
7cb88a7f-385d-4e60-a457-de5706d40114-S0 at slave(461)@192.10.1.5:65267 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1116 01:02:18.408365 35608 master.cpp:3289] Disconnecting agent 
7cb88a7f-385d-4e60-a457-de5706d40114-S0 at slave(461)@192.10.1.5:65267 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1116 01:02:18.409376 35608 master.cpp:3308] Deactivating agent 
7cb88a7f-385d-4e60-a457-de5706d40114-S0 at slave(461)@192.10.1.5:65267 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1116 01:02:18.409376 29076 hierarchical.cpp:357] Removed framework 
7cb88a7f-385d-4e60-a457-de5706d40114-
I1116 01:02:18.409376 29076 hierarchical.cpp:801] Agent 
7cb88a7f-385d-4e60-a457-de5706d40114-S0 deactivated
I1116 01:02:18.410392 36704 containerizer.cpp:2465] Destroying container 
3d01f94a-7f62-4e39-9e72-1c01efa1f801 in RUNNING state
I1116 01:02:18.410392 36704 containerizer.cpp:3132] Transitioning the state of 
container 3d01f94a-7f62-4e39-9e72-1c01efa1f801 from RUNNING to DESTROYING
I1116 01:02:18.411383 36704 launcher.cpp:161] Asked to destroy container 
3d01f94a-7f62-4e39-9e72-1c01efa1f801
W1116 01:02:18.412376 37076 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5312 to peer '192.10.1.5:50697': IO[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (703 ms total)

[--] Global test environment tear-down
[==] 1053 tests from 103 test cases ran. (493241 ms total)
[  PASSED  ] 1051 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

 failed with error code: The specified network name is no longer available.

W1116 01:02:18.412376 37076 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5648 to peer '192.10.1.5:50696': IO failed with error 
code: The specified network name is no longer available.

I1116 01:02:18.441385 37260 containerizer.cpp:2971] Container 
3d01f94a-7f62-4e39-9e72-1c01efa1f801 has exited
I1116 01:02:18.471369 39316 master.cpp:1115] Master terminating
I1116 01:02:18.473381 37260 hierarchical.cpp:643] Removed agent 
7cb88a7f-385d-4e60-a457-de5706d40114-S0
I1116 01:02:19.054217 37076 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 16, 2018, midnight, Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69359/
> ---
> 
> (Updated Nov. 16, 2018, midnight)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the `ReconcileDroppedOperation` test relies on converting
> preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
> this test is rewritten to create two disks from a storage pool, with one
> operation dropped.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 077a46585bd56181ba199dc529e09f38f4971338 
> 
> 
> Diff: https://reviews.apache.org/r/69359/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

2018-11-15 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/
---

Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

Previously the `ReconcileDroppedOperation` test relies on converting
preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
this test is rewritten to create two disks from a storage pool, with one
operation dropped.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
077a46585bd56181ba199dc529e09f38f4971338 


Diff: https://reviews.apache.org/r/69359/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao